feat: add lowlights — death-based clip saving (mirrors highlights)#153
Open
giou wants to merge 7 commits into
Open
feat: add lowlights — death-based clip saving (mirrors highlights)#153giou wants to merge 7 commits into
giou wants to merge 7 commits into
Conversation
added 2 commits
June 9, 2026 18:04
The Compress option was only shown for Clip and Highlight types. Added Lowlight to the condition so the dropdown menu matches the other content types (Copy, Rename, Open File Location, Compress, Delete).
Both buttons were only shown for Clip/Highlight/Buffer types. Added Lowlight to match the full dropdown (Upload with yellow text, Copy, Rename, Open File Location, Compress, Delete).
Adds 'Lowlight' to the video.type check that gates the Upload and Copy buttons in the video player toolbar, so lowlights behave the same as highlights and clips.
Owner
|
Thank you for the contribution. There are still a few things left to address:
|
- menu.tsx: respect the sidebar visibility toggle for Lowlights like the other items, while still gating the menu by enableLowlights. Splits the old behaviour into 'item.visible && settings.enableLowlights', so users who turn the feature off get the item hidden in any state, and users who leave it on get the standard sidebar toggle behaviour plus the default placement (above Settings). - LowlightsSection.tsx: drop the inner 'box inside a box' wrapper so the section layout matches HighlightsSection exactly.
Author
|
Thanks for the review, should be fixed now, let me know if I missed anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in League of Legends. Disabled by default.