Merged
Conversation
davschneller
changed the title
davschneller
force-pushed
the
davschneller/installfix
branch
from
27a5014 to
4416072
Compare
marcmath
approved these changes
Mar 24, 2026
marcmath
left a comment
marcmath
left a comment
There was a problem hiding this comment.
I verified that the package installs correctly. Everything looks good to me.
Contributor
Author
|
Thanks alot for the review, @marcmath |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do:
setup.pyfor legacy setupspspammfolder topypspammto avoid collision with the legacypspamm.pyinstall method (as still used by Spack as of now) which could also be treated as a module file.pspamm.py(pending: adjust spack package to install pspamm as a Python module)Hopefully it'll also help with #13 and #19.