Skip to content

feat: Pipeline swap endpoint #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darkheir wants to merge 2 commits into
base: sekoia
Choose a base branch
from
Open

feat: Pipeline swap endpoint #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
901d3e5
feat: Pipeline swap endpoint
Darkheir Apr 10, 2026
f4bba46
feat: Apply PR review suggestions
Darkheir Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions quickwit/quickwit-control-plane/src/control_plane.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ use quickwit_metastore::{CreateIndexRequestExt, CreateIndexResponseExt, IndexMet
use quickwit_proto::control_plane::{
AdviseResetShardsRequest, AdviseResetShardsResponse, ControlPlaneError, ControlPlaneResult,
GetOrCreateOpenShardsRequest, GetOrCreateOpenShardsResponse, GetOrCreateOpenShardsSubrequest,
SwapIndexingPipelinesRequest, SwapIndexingPipelinesResponse,
};
use quickwit_proto::indexing::ShardPositionsUpdate;
use quickwit_proto::metastore::{
Expand Down Expand Up @@ -353,7 +354,7 @@ impl ControlPlane {
let physical_indexing_plan: Vec<JsonValue> = self
.indexing_scheduler
.observable_state()
.last_applied_physical_plan
.current_targetted_physical_plan
.map(|plan| {
plan.indexing_tasks_per_indexer()
.iter()
Expand Down Expand Up @@ -953,6 +954,20 @@ impl Handler<AdviseResetShardsRequest> for ControlPlane {
}
}

#[async_trait]
impl Handler<SwapIndexingPipelinesRequest> for ControlPlane {
type Reply = ControlPlaneResult<SwapIndexingPipelinesResponse>;

async fn handle(
&mut self,
request: SwapIndexingPipelinesRequest,
_ctx: &ActorContext<Self>,
) -> Result<Self::Reply, ActorExitStatus> {
let response = self.indexing_scheduler.swap_pipelines(request);
Ok(response)
}
}

#[async_trait]
impl Handler<LocalShardsUpdate> for ControlPlane {
type Reply = ControlPlaneResult<()>;
Expand Down Expand Up @@ -1906,7 +1921,7 @@ mod tests {
control_plane_mailbox.ask(Observe).await.unwrap();
let last_applied_physical_plan = control_plane_obs
.indexing_scheduler
.last_applied_physical_plan
.current_targetted_physical_plan
.unwrap();
let indexing_tasks = last_applied_physical_plan
.indexing_tasks_per_indexer()
Expand Down Expand Up @@ -1937,7 +1952,7 @@ mod tests {
control_plane_mailbox.ask(Observe).await.unwrap();
let last_applied_physical_plan = control_plane_obs
.indexing_scheduler
.last_applied_physical_plan
.current_targetted_physical_plan
.unwrap();
let indexing_tasks = last_applied_physical_plan
.indexing_tasks_per_indexer()
Expand Down
Loading
Loading