Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Quickwit’s Tantivy dependency to the upstream tantivy crate v0.26, replacing the prior git-rev dependency, and adjusts indexing directory wrapper code to match updated trait bounds.
Changes:
- Switch
tantivydependency from a git revision to crates.iotantivy = 0.26.0with existing feature flags. - Update
ControlledDirectorywriter types to usedyn TerminatingWrite + Send + Syncto match Tantivy 0.26 expectations. - Refresh
Cargo.lockto reflect the new Tantivy release and transitive dependency graph changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| quickwit/quickwit-indexing/src/controlled_directory.rs | Updates TerminatingWrite trait object bounds to include Send + Sync for Tantivy 0.26 compatibility. |
| quickwit/Cargo.toml | Moves Tantivy from a git dependency to crates.io v0.26.0 (keeps feature set). |
| quickwit/Cargo.lock | Updates lockfile for Tantivy 0.26.0 and related transitive dependency changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rdettai-sk
force-pushed
the
upgrade-tantivy-026
branch
from
ec438ea to
bc6c26a
Compare
rdettai-sk
force-pushed
the
upgrade-tantivy-026
branch
from
bc6c26a to
68b9c84
Compare
rdettai-sk
commented
Apr 15, 2026
Collaborator
Author
There was a problem hiding this comment.
Some changes affected how these are calculated, but the assertions changed here were actually lacking precision already (floating point and approx cardinality).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move to Tantivy 0.26. The previous patches and composite aggregations are included.
How was this PR tested?
Describe how you tested this PR.