Skip to content

[js] Fix failing javascript tests #17293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asolntsev merged 2 commits into from
Apr 2, 2026
+9 −15
Merged

[js] Fix failing javascript tests #17293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9414c
fix failing test "can unpin script" in "webdriver_script_test.js"
asolntsev Apr 2, 2026
c83ae06
remove unneeded delays in "webdriver_script_test.js"
asolntsev Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions javascript/selenium-webdriver/test/lib/webdriver_script_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ suite(
await driver.quit()
})

function delay(ms) {
return new Promise((resolve) => setTimeout(resolve, ms))
}

describe('script()', function () {
it('can listen to console log', async function () {
let log = null
Expand All @@ -49,8 +45,6 @@ suite(
await driver.get(Pages.logEntryAdded)
await driver.findElement({ id: 'consoleLog' }).click()

await delay(3000)

assert.equal(log.text, 'Hello, world!')
assert.equal(log.realm, null)
assert.equal(log.type, 'console')
Expand All @@ -69,8 +63,6 @@ suite(
await driver.get(Pages.logEntryAdded)
await driver.findElement({ id: 'jsException' }).click()

await delay(3000)

assert.equal(log.text, 'Error: Not working')
assert.equal(log.type, 'javascript')
assert.equal(log.level, 'error')
Expand Down Expand Up @@ -133,26 +125,28 @@ suite(

await driver.get(Pages.logEntryAdded)

await delay(3000)

assert.equal(log.text, 'Hello!')
})

it('can unpin script', async function () {
const id = await driver.script().pin("() => { console.log('Hello!'); }")
const id = await driver.script().pin("() => { console.log('Hello'); }")
await driver.script().pin("() => { console.log('World'); }")

let count = 0
const logs = []
await driver.script().addConsoleMessageHandler((logEntry) => {
count++
logs.push(logEntry.text)
})

await driver.get(Pages.logEntryAdded)
assert.ok(logs.includes('Hello'), `[${logs}] should contain "Hello"`)
assert.ok(logs.includes('World'), `[${logs}] should contain "World"`)

await driver.script().unpin(id)

logs.length = 0
await driver.get(Pages.logEntryAdded)

assert.equal(count, 1)
assert.ok(logs.includes('World'), `[${logs}] should contain "World"`)
assert.ok(!logs.includes('Hello'), `[${logs}] should not contain "Hello"`)
})
})
},
Expand Down
Loading