[rb] fix Ruby tests failing because of alerts in Firefox#17294
Open
asolntsev wants to merge 7 commits intoSeleniumHQ:trunkfrom
Open
[rb] fix Ruby tests failing because of alerts in Firefox#17294asolntsev wants to merge 7 commits intoSeleniumHQ:trunkfrom
asolntsev wants to merge 7 commits intoSeleniumHQ:trunkfrom
Conversation
Seems that Firefox behavior with alerts was changed. Without "unhandledPromptBehavior" capability, command `wait_for_alert` is always failing in FireFox.
Contributor
Review Summary by QodoFix Ruby tests failing due to Firefox alert handling
WalkthroughsDescription• Adds unhandled_prompt_behavior capability to Firefox options • Fixes wait_for_alert command failures in Firefox tests • Sets unhandled_prompt_behavior to 'ignore' by default File Changes1. rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
cgoldberg
approved these changes
Apr 2, 2026
Member
|
I pushed a fix to this branch to try to fix the symlink issue in Ruby tests. I have no idea why we just started seeing that |
Contributor
Author
|
@cgoldberg Seems that now all tests are passing, but the failure is something new: :( :( |
Member
|
I think that #17281 caused that one. I just pinged @nvborisenko in Slack. We're almost there :) |
Member
|
I reverted my attempt at fixing the symlink issue for ruby. rules_ruby is creating a recursive symlink that is causing it fail... but I don't know how to fix it or why it's happening. It's only happening on Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that Firefox behavior with alerts was changed. Without "unhandledPromptBehavior" capability, command
wait_for_alertis always failing in FireFox.🔗 Related Issues
e.g. https://github.com/SeleniumHQ/selenium/actions/runs/23901428682/job/69699326193?pr=17287
💥 What does this PR do?
Adds capability "unhandled_prompt_behavior"="ignore" to firefox options.
🔄 Types of changes