reject promise with native error code#137
Open
Qanlevon wants to merge 1 commit intoSelfLender:masterfrom
weaspire:android-error-code
Open
reject promise with native error code#137Qanlevon wants to merge 1 commit intoSelfLender:masterfrom weaspire:android-error-code
Qanlevon wants to merge 1 commit intoSelfLender:masterfrom
weaspire:android-error-code
Conversation
This was referenced Sep 13, 2020
Member
|
I am totally open to doing this. I think that we should expose the constants so they can easily be referenced when writing code to handle the errors. Also, we should update the README.md to demonstrate the usage of the error handling. |
|
Is this commit merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to handle native Android error with a complete list of error code
https://developer.android.com/reference/androidx/biometric/BiometricPrompt#constants_1