Skip to content

Bug: Fix subtemplate events in each blocks#249

Merged
jlukic merged 1 commit into
mainfrom
bug/subtemplate-each-events
Jun 11, 2026
Merged

Bug: Fix subtemplate events in each blocks#249
jlukic merged 1 commit into
mainfrom
bug/subtemplate-each-events

Conversation

@jlukic

@jlukic jlukic commented Jun 11, 2026

Copy link
Copy Markdown
Member

Fixes issue where subtemplate events in native renderer failed when templates were not nested.

Additional Changes

  • subtemplate-events-each example — per-instance subtemplate state and events in a list

Risk

3/10

Bugfix in hot path but 2 lines and obvious.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
semantic-next Ready Ready Preview, Comment Jun 11, 2026 6:57pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
mcp Ignored Ignored Preview Jun 11, 2026 6:57pm

Request Review

@semantic-performance-bot

Copy link
Copy Markdown

⚪ No Meaningful Change for cded4b8 on Benchmark Suite 📊

Base: main · Action: #27370199263 · Raw: bench-report.json

Bug: Fix subtemplate events in each blocks

Note

This PR did not move any measured metrics.

✅ 0 faster · ❌ 0 slower · 🔍 30 unsure · ⚪ 19 no change


⚪ No Change (19)

Metrics where this PR measured within ±2% of main — no meaningful performance change detected.

metric Change
build-html-string-10k -1.4% – +0.3%
todo:bulk-add-500 -0.5% – +0.8%
krausest:clear-10k -1.7% – +0.8%
todo:clear-completed-250 -1.2% – +1.3%
krausest:create-10k -0.3% – +0.4%
each-100 -1.3% – +1.1%
each-100-mount -0.5% – +1.9%
template:each-mount-1000 -0.9% – +0.5%
todo:edit-start-10 -1.7% – +1.1%
expr-js-10k -1.1% – +1.6%
expr-lisp-50k -1.4% – +1.4%
todo:filter-cycle-20 -0.8% – +0.5%
helper-100-mount -0.4% – +1.6%
todo:remove-50-back -1.4% – +1.5%
krausest:replace-1k -1.0% – +0.9%
template:subtemplate-data-blob-100 -0.2% – +1.4%
template:subtemplate-helpers-heavy-100x500 -0.8% – +0.3%
template:subtemplate-reactive-data-100x500 -2.0% – +1.1%
todo:toggle-all-200 -0.5% – +0.5%
🔍 Unsure (30)

Too Fast to Measure Precisely (30)

On benches this short, OS jitter, GC, and JIT pauses drown out anything under 4%. Bigger changes than that still show up.

metric Change Test Time Expected Noise
template:active-indicator-200 -1.3% – +3.4% ~37ms ±8%
template:active-indicator-nested-200 -3.9% – +1.1% ~21ms ±8%
todo:add-20 -0.5% – +2.1% ~8ms ±4%
krausest:append-1k -3.3% – +2.6% ~82ms ±7%
krausest:create-1k -0.9% – +2.3% ~77ms ±5%
dom-walker-1000x15 -0.9% – +2.1% ~37ms ±7%
todo:edit-cycle-5 -1.3% – +2.7% ~67ms ±4%
expr-simple-100k -2.8% – +0.5% ~23ms ±7%
helper-100-state-change-1k -3.3% – +0.5% ~4ms ±8%
todo:remove-50-front -0.6% – +2.2% ~5ms ±3%
todo:remove-50-middle -3.4% – +3.8% ~5ms ±10%
todo:remove-first-100 -2.0% – +2.6% ~15ms ±6%
todo:remove-last-100 -2.0% – +0.8% ~14ms ±4%
todo:remove-middle-100 -3.8% – +4.3% ~13ms ±10%
krausest:remove-row-back-100 -3.7% – +2.5% ~26ms ±8%
krausest:remove-row-front-20 -3.5% – +3.5% ~9ms ±9%
krausest:remove-row-middle-20 -4.7% – +4.3% ~6ms ±11%
todo:rename-500 -6.3% – +4.3% ~19ms ±13%
krausest:select-40 -5.5% – +2.9% ~5ms ±11%
template:snippet-args-per-key-100x500 -1.1% – +2.2% ~35ms ±6%
template:snippet-in-subtemplate-100x1k -1.2% – +2.5% ~25ms ±6%
template:stable-ref-mutate-500 -1.6% – +4.7% ~15ms ±10%
template:subtemplate-helpers-light-100x500 -2.3% – +0.2% ~73ms ±4%
template:subtemplate-shorthand-props-100x500 -2.9% – +0.6% ~43ms ±6%
krausest:swap-rows-20 -1.7% – +2.5% ~13ms ±5%
todo:toggle-100 -3.1% – +2.4% ~9ms ±7%
todo:toggle-first-100 -3.0% – +2.3% ~15ms ±7%
todo:toggle-last-100 -3.0% – +1.7% ~15ms ±6%
todo:toggle-middle-100 -0.4% – +4.4% ~13ms ±8%
krausest:update-10th-50 -0.6% – +3.5% ~27ms ±5%
📖 Bench glossary (40 metrics)
metric what it tests
krausest:append-1k Appends 1000 new rows onto an existing 1000-row table.
krausest:clear-10k Clears a 10000-row table back to empty in a single operation.
krausest:create-10k Renders a fresh 10000-row table into an empty parent at ten times the create-1k scale.
krausest:create-1k Renders a fresh 1000-row table into an empty parent.
krausest:remove-row-back-100 Removes the last row 100 times from a 1000-row table, with no other rows needing to move.
krausest:remove-row-front-20 Removes the first row 20 times from a 1000-row table, with all remaining rows sliding up each time.
krausest:remove-row-middle-20 Removes the middle row 20 times from a 1000-row table, with the rows below it sliding up each time.
krausest:replace-1k Replaces 1000 rows with a fresh 1000-row set, diffing the keyed list against a populated table.
krausest:select-40 Highlights one row at a time across 40 rows so only the previous and newly highlighted rows update.
krausest:swap-rows-20 Swaps the second and second-to-last rows in a 1000-row table, repeated 20 times.
krausest:update-10th-50 Updates the label on every tenth row of a 1000-row table, looped 50 times to lift the work above noise.
template:active-indicator-200 Cycles selectedId across 200 list items. Only the previously and newly active items update their class.
template:active-indicator-nested-200 Cycles currentUrl through 50 leaf urls in a 5×10×4 nav. Only the previously and newly active leaves should update their…
template:each-mount-1000 Mounts a fresh 1000-item each block with five-field items so per-record allocation cost dominates the wall clock.
template:snippet-args-per-key-100x500 Mutates one snippet arg's source across 100 invocations, 500 cycles. Adjacent no-signal expressions stay quiet.
template:snippet-in-subtemplate-100x1k Mutates one subtemplate prop's source across 25 cards each invoking 4 inner snippets, 1000 cycles. Snippet bodies shoul…
template:stable-ref-mutate-500 Replaces one item by index in a 500-item list across 100 cycles. Only that item's expressions re-render.
template:subtemplate-data-blob-100 Mutates one field inside data=expression on 100 children. Every child re-renders by design.
template:subtemplate-helpers-heavy-100x500 100 subtemplates, 4 inner bindings where three call helpers shaped like userland reality — Intl.NumberFormat, Array.fin…
template:subtemplate-helpers-light-100x500 100 subtemplates, 4 inner bindings each calling formatDate / classIf / capitalize, 500 cycles. Mutates one source signa…
template:subtemplate-reactive-data-100x500 Mutates one verbose reactiveData field across 100 child subtemplates, 500 cycles. Only the changed field re-evaluates.
template:subtemplate-shorthand-props-100x500 Mutates one shorthand prop's source across 100 child subtemplates, 500 cycles. Only that prop re-evaluates.
todo:add-20 Appends 20 todo items one at a time, like a user typing entries in a row.
todo:bulk-add-500 Renders 500 todo items added at once from a single data load.
todo:clear-completed-250 Clears 250 completed items from a 500-item list in one action, like clicking clear completed.
todo:edit-cycle-5 Runs 5 full edit-then-save cycles on different items, like editing a row and saving it.
todo:edit-start-10 Enters edit mode on 10 different items in a row, like double-clicking each one.
todo:filter-cycle-20 Cycles through active, completed, and all filters 20 times on a 100-item list.
todo:remove-50-back Deletes 50 items from the end of a 100-item list, one click at a time.
todo:remove-50-front Deletes 50 items from the front of a 100-item list, one click at a time.
todo:remove-50-middle Deletes 50 items from the middle of a 100-item list, one click at a time.
todo:remove-first-100 Deletes the first item 100 times from a 200-item list, with remaining items moving up each time.
todo:remove-last-100 Deletes the last item 100 times from a 200-item list, with no other items needing to move.
todo:remove-middle-100 Deletes the middle item 100 times from a 200-item list, walking halfway through to find each target.
todo:rename-500 Renames items in a 100-item list 500 times via single-field setProperty without editingId co-fires.
todo:toggle-100 Cycles through the first 10 items 10 times each, like a user toggling items repeatedly down a list.
todo:toggle-all-200 Toggles all 100 items completed and back across 200 cycles via the master checkbox.
todo:toggle-first-100 Toggles the first item in a 100-item list 100 times, alternating completed on and off.
todo:toggle-last-100 Toggles the last item in a 100-item list 100 times, alternating completed on and off.
todo:toggle-middle-100 Toggles a middle item in a 100-item list 100 times, alternating completed on and off.

Sample size: 80 floor / 260 max · Noise floor: ±2% · Timeout: 3min · Wall-clock: 12m17s

@jlukic jlukic merged commit 1ff8d40 into main Jun 11, 2026
15 checks passed
@jlukic jlukic deleted the bug/subtemplate-each-events branch June 11, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Templating Modifies templating package Tests Modifies tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant