Open
Conversation
khornberg
reviewed
Aug 2, 2017
Contributor
khornberg
left a comment
khornberg
left a comment
There was a problem hiding this comment.
I like this method and use it in other projects.
I particularly like that the code which is used to produced the view is then available to see.
| app.import(app.bowerDirectory + "/highlightjs/highlight.pack.min.js"); | ||
|
|
||
| app.import(app.bowerDirectory + "/highlightjs/styles/github-gist.css"); | ||
| app.import(app.bowerDirectory + "/highlightjs/styles/hybrid.css"); |
Contributor
There was a problem hiding this comment.
If highlightjs is gone are these necessary?
Collaborator
Author
There was a problem hiding this comment.
Highlightjs is dependency https://github.com/ef4/ember-code-snippet/blob/master/package.json
Collaborator
|
looks like a good way to do this |
snitin315
reviewed
Feb 10, 2020
Contributor
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
Please Resolve your conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to change the way we get the code snippet in the documentation.
What this solves?
This project also use it.
https://github.com/miguelcobain/ember-paper
https://github.com/ef4/ember-code-snippet
If they agree, I can replicate it for all the documentation.