Skip to content

fix: filter stale config data when parallelism settings change between runs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adibarra merged 1 commit into from
Mar 19, 2026
Merged

fix: filter stale config data when parallelism settings change between runs #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/app/src/components/inference/hooks/useChartData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,25 @@ export function useChartData(
if (!allRows || !sequenceIslOsl) return [];
const seqFilter = (r: { isl: number; osl: number }) =>
r.isl === sequenceIslOsl.isl && r.osl === sequenceIslOsl.osl;
const mainRows = allRows
.filter(seqFilter)
.map((r) => (selectedRunDate ? { ...r, date: selectedRunDate, actualDate: r.date } : r));
const seqFiltered = allRows.filter(seqFilter);

// For each (hw, framework, spec_method, disagg, precision) group, keep only
// rows from the most recent date. When parallelism settings change between runs,
// old config_ids create stale data points under the same legend line — drop them.
const maxDatePerGroup = new Map<string, string>();
for (const r of seqFiltered) {
const key = `${r.hardware}|${r.framework}|${r.spec_method}|${r.disagg}|${r.precision}`;
const cur = maxDatePerGroup.get(key);
if (!cur || r.date > cur) maxDatePerGroup.set(key, r.date);
}
const deduped = seqFiltered.filter((r) => {
const key = `${r.hardware}|${r.framework}|${r.spec_method}|${r.disagg}|${r.precision}`;
return r.date === maxDatePerGroup.get(key);
});

const mainRows = deduped.map((r) =>
selectedRunDate ? { ...r, date: selectedRunDate, actualDate: r.date } : r,
);
if (comparisonDates.length === 0) return mainRows;
const extraRows = comparisonQueries.flatMap((q, i) =>
(q.data ?? [])
Expand Down