Cleanup conf files#25
Conversation
Apply the HCI IPC fragment through sysbuild and explicitly configure controller PHY, TX power, and external 20 ppm LF clock settings.
Remove inactive settings and make LFXO, connection-parameter, PHY, and data-length behavior explicit.
...So that AI can build projects
dman82499
left a comment
dman82499
left a comment
There was a problem hiding this comment.
I'm confused on some of the functionality and some things seem redundant, see individual comments on details, but other than that it seems fine.
| #CONFIG_DEBUG_COREDUMP=y | ||
| #CONFIG_DEBUG_COREDUMP_BACKEND_LOGGING=y | ||
| CONFIG_DEBUG_INFO=y | ||
| CONFIG_EXCEPTION_STACK_TRACE=y |
There was a problem hiding this comment.
the stack trace was still useful for me when looking at the crashes I believe, unless there's something else keeping it enabled
| @@ -0,0 +1,8 @@ | |||
| # Apply the project-owned configuration fragment to the network-core HCI IPC | |||
| # image selected in sysbuild.conf. | |||
| if(SB_CONFIG_NETCORE_HCI_IPC) | |||
There was a problem hiding this comment.
this is redundant, it will auto happen by sysbuild
| CONFIG_BT_CTLR_PHY_CODED=y | ||
|
|
||
|
|
||
| # Workaround: Unable to allocate command buffer when using K_NO_WAIT since |
There was a problem hiding this comment.
I don't understand what these do or why they are important but I will trust you on that
| @@ -1,23 +1,38 @@ | |||
| CONFIG_IPC_SERVICE=y | |||
There was a problem hiding this comment.
that's necessary? seems strange. I thought that was deprecated because sysbuild should be processing that. Or basically sysbuild should auto set IPC Service and MBox, when I do SB_CONFIG_CHLID_IMAGE_IPC which is in the sysbuild file.
2 participants
These are changes / cleanups I am proposing for the ECG mote that I deem worthy of backporting to the PPG. More to come.
The conf file child_image/hci_ipc.conf (i.e., the network core settings) was not included in the build. Instead the Zephyr default sample was being used. This was largely not a problem but it did reduce Tx power from +3dBm to +0dBm
I fixed the build to add our conf file back in, however I copied over the sample defaults for a clean start. None should matter too much although this needs a little testing. I also explicitly included some previously implicit default values for clarity. I kept the reduced Tx power so note that it can be increased to +3dBm if desired. Ask me if you'd like more information on any setting in particular.
I also did a treatment to the prj.conf file (application core settings) . I removed some unused settings and edited some comments. Made some implicit defaults explicit.
All of this is to hopefully make it more clear where a particular setting is done although DT still makes this hard. There should be no functional change.
I also added a powershell wrapper script to allow AI agents to build nRF SDK / west projects instead of having to initiate under VScode. At least Codex needs this, did not try Claude or others. I don't normally do this but it is convenient sometimes. Add a note about the tools directory to your AGENTS.md file or whatever. The wrapper is currently fragile and if you have different tool paths or change the SDK or toolchain it will probably need adjustment.