Skip to content

[PLAT-1078] Fix/polygon split #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TrevorBurgoyne merged 3 commits into from
Apr 2, 2025
Merged

[PLAT-1078] Fix/polygon split #213

TrevorBurgoyne merged 3 commits into from
Apr 2, 2025

Conversation

@TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Apr 2, 2025 •
edited
Loading

Fix/polygon split

PLAT-1078

Description

  • Fixed bug introduced in v0.15.0 where using the erase tool such that a polygon was separated into multiple disjoint regions would cause an unrecoverable error.
  • Steps to reproduce in v0.15.0-v0.16.1:
    • use the erase tool to erase a portion of a polygon such that it would divide it into two or more separate regions

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

no

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Apr 2, 2025
TrevorBurgoyne
TrevorBurgoyne commented Apr 2, 2025
View reviewed changes
TrevorBurgoyne
TrevorBurgoyne commented Apr 2, 2025
View reviewed changes
joshua-dean
joshua-dean approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@joshua-dean joshua-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix
LGTM 🚀

@TrevorBurgoyne TrevorBurgoyne merged commit 55a20f6 into main Apr 2, 2025
1 check passed
@TrevorBurgoyne TrevorBurgoyne deleted the fix/polygon-split branch April 2, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshua-dean joshua-dean joshua-dean approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBurgoyne @joshua-dean