Skip to content

Conversation

@TrevorBurgoyne
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne commented Apr 25, 2025

Fix/vanish

Description

Fix inconsistencies relating to the vanish button:

  • Fix bug where the Vanish button wouldn't update its locked state when switching between subtasks.
  • Fix bug where clicking the Vanish button would unexpectedly set the size cookie, causing future annotations in the same subtask to be loaded in a very small size on subsequent sessions, with the only way to recover being to increase the annotation size.
    • To replicate in previous version: Load the ULabel demo resume_from.html, and click the vanish button. Then refresh the page, and the annotations will remain vanished but the vanish button is not locked. Toggling the vanish button does nothing, to recover annotations, increase the annotation size.

PLAT-1079

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

Subtasks that are vanished or set to the smallest possible size no longer have that size saved in the annotation size cookie.

@TrevorBurgoyne TrevorBurgoyne added the bug Something isn't working label Apr 25, 2025
Copy link
Collaborator

@joshua-dean joshua-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fix it 👍

@TrevorBurgoyne TrevorBurgoyne merged commit 6b8c9b1 into main Apr 25, 2025
1 check passed
@TrevorBurgoyne TrevorBurgoyne deleted the fix/vanish-cookie branch April 25, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants