-
Notifications
You must be signed in to change notification settings - Fork 5
[PLAT-1279] Feature/size mode #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding @CarterSolberg as he worked on the deprecated version of a similar feature in the past |
joshua-dean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small notes. Like the demo cleanup
|
Also, I don't really foresee it being a need, but while we're here: can you think of any reason we'd want to scale the Definitely not necessary for this PR, but maybe worth thinking about. |
Size mode
PLAT-1279
Description
size_modeargument to theULabelconstructor, which allows users to specify how the size of annotations should be scaled when the zoom level is changed.fixed,zoom, andinverse-zoom.fixed, the line size of annotations will remain constant regardless of zoom level.zoom, the line size of annotations will increase with increased zoom level.inverse-zoom, the line size of annotations will decrease with increased zoom level.size_mode = "fixed".demologicPR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsnpm installandnpm run buildAFTER bumping the version numberapi_spec.md)changelog.mdBreaking API Changes
no