-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/tests #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tests #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces automated testing infrastructure to the ULabel project and addresses several build and code quality issues. The main purpose is to establish Jest for unit testing and Playwright for end-to-end testing, while fixing circular webpack builds that were causing bundle bloat.
Key changes include:
- Addition of comprehensive test suites covering core ULabel functionality and annotation operations
- Implementation of build optimizations that reduced bundle size from ~20 MB to 1 MB
- Refactoring of import statements and console logging to use proper TypeScript patterns and centralized logging
Reviewed Changes
Copilot reviewed 33 out of 41 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ | New testing infrastructure with Jest unit tests and Playwright e2e tests |
| package.json | Added testing dependencies and scripts, version bump to 0.19.1 |
| src/ | TypeScript import fixes using import type and centralized error logging |
| .github/workflows/test.yml | CI/CD pipeline for automated testing |
| playwright.config.js | Playwright configuration for e2e testing |
| eslint.config.mjs | ESLint rules for test files |
joshua-dean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only thing I can think of would be to rename tests/utils -> tests/testing-utils (or tests/testing_utils), just in case we end up with an src/utils in the future.
Testing
Description
jestplaywrightand the demo appdist/directory before each buildimport type... from ".."instead of justimportto fix ts not properly resolving imports to jsconsole.warnandconsole.errorinstances to uselog_messageparent_idfield fromULabelAnnotationPR Checklist
package.jsonhas been bumped since last releasepackage.jsonandsrc/version.jsnpm installandnpm run buildAFTER bumping the version numberapi_spec.md)changelog.mdBreaking API Changes
parent_idis no longer included for annotations, but afaik it was always null anyways