Replace fragile SAML regex XML parsing with DOM-based extraction#120
Merged
Conversation
Add backup_codes_shown flag to user_mfa table. Backup codes are only returned on the initial setup request and marked as shown afterwards. Re-running setup will regenerate codes but not display them. Add a /mfa/rotate-backup-codes endpoint that requires current TOTP token to view new backup codes.
Prevent token leak by removing the raw passwordless token from the API response body. The token is still stored hashed in the database and can be verified via /auth/passwordless/verify. The response now only returns a generic success message.
Replace 4 fragile regex patterns for extracting NameID and SAML attribute values with robust DOM-based extraction using the already-parsed XML document. This fixes namespace sensitivity, encoding variations, and CDATA handling issues. Also moves the DOMParser outside the SAML_IDP_CERT conditional so it is always available for attribute extraction.
Senthil455
commented
Jun 17, 2026
Senthil455
left a comment
Senthil455
left a comment
Owner
Author
There was a problem hiding this comment.
Replaces regex-based XML parsing with DOM methods already available from the signature verification code. Handles namespace variations, CDATA, encoding, and whitespace correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 4 regex patterns for extracting NameID and SAML attribute values with robust DOM-based extraction using the already-parsed XML document. Moved DOMParser outside the SAML_IDP_CERT conditional to ensure doc is always available for attribute extraction.