ci: reuse test workflow in release so dynamodb is covered#20
Merged
Conversation
The release workflow had a hand-maintained copy of the test job that drifted
behind test.yml and didn't enable backend-dynamodb (or start a DynamoDB Local
service), so tests/dynamodb.rs failed with NoMatchingBackend("dynamodb")
during release. Add workflow_call to test.yml and have release.yml invoke it
so a release is always gated on the same backend matrix as PRs and main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testsjob was a hand-maintained copy oftest.ymlthat had drifted: it didn't enablebackend-dynamodbor start a DynamoDB Local service, sotests/dynamodb.rsfailed during release withNoMatchingBackend("dynamodb").workflow_call:trigger totest.ymland haverelease.ymlinvoke it viauses: ./.github/workflows/test.yml, so releases are always gated on the same backend matrix (including DynamoDB) as PRs and pushes tomain. No more drift.Test plan
releaseworkflow viaworkflow_dispatchon this branch and confirm the reused test job runs the full matrix (redis, dynamodb, couchdb, surrealdb, sqlite, filesystem, in-memory) and passes before the publish step.