Skip to content

deprecate gha artifact name#2

Merged
tmclaugh merged 3 commits intomainfrom
feature/deprecate-gha-artifact-name
Apr 23, 2026
Merged

deprecate gha artifact name#2
tmclaugh merged 3 commits intomainfrom
feature/deprecate-gha-artifact-name

Conversation

@tmclaugh
Copy link
Copy Markdown
Member

When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it

Copilot AI review requested due to automatic review settings April 23, 2026 21:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the artifact naming override logic from the gha-setup-workspace composite action, based on the updated understanding that GitHub Actions artifact names do not need to be made unique per-run to avoid overwrites.

Changes:

  • Removed the artifact_name_override input and the artifact-name output from the action interface.
  • Deleted the ServerlessOpsIO/gha-artifact-name@v1 step and stopped passing an explicit artifact name into actions/download-artifact.
  • Updated README documentation to reflect the simplified behavior and removed the artifact naming configuration section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
action.yaml Removes artifact name override input/output and the intermediate naming step; download step now relies on download-artifact defaults.
README.md Removes artifact naming docs and updates inputs/outputs and behavior description accordingly.
Comments suppressed due to low confidence (1)

action.yaml:12

  • Removing the artifact_name_override input and artifact-name output is a breaking interface change for existing action consumers. Consider keeping the input/output as deprecated (no-op) for a transition period, or publishing this change under a new major tag (e.g., v2) so existing workflows pinned to @v1 don't unexpectedly break.
inputs:
  checkout_fetch_depth:
    description: Depth to fetch repository
    required: false
    default: '1'
  checkout_artifact:
    description: Whether to checkout artifact instead of source
    required: false
    default: 'false'

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yaml
Comment thread README.md Outdated
Comment thread README.md Outdated
@tmclaugh tmclaugh force-pushed the feature/deprecate-gha-artifact-name branch from 2b4a0f2 to 273b5ad Compare April 23, 2026 21:27
When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it. Not sure we ever needed it.
@tmclaugh tmclaugh force-pushed the feature/deprecate-gha-artifact-name branch from 66e719d to 3f2487b Compare April 23, 2026 22:07
@tmclaugh tmclaugh merged commit f5cc177 into main Apr 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants