Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the artifact naming override logic from the gha-setup-workspace composite action, based on the updated understanding that GitHub Actions artifact names do not need to be made unique per-run to avoid overwrites.
Changes:
- Removed the
artifact_name_overrideinput and theartifact-nameoutput from the action interface. - Deleted the
ServerlessOpsIO/gha-artifact-name@v1step and stopped passing an explicit artifact name intoactions/download-artifact. - Updated README documentation to reflect the simplified behavior and removed the artifact naming configuration section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| action.yaml | Removes artifact name override input/output and the intermediate naming step; download step now relies on download-artifact defaults. |
| README.md | Removes artifact naming docs and updates inputs/outputs and behavior description accordingly. |
Comments suppressed due to low confidence (1)
action.yaml:12
- Removing the
artifact_name_overrideinput andartifact-nameoutput is a breaking interface change for existing action consumers. Consider keeping the input/output as deprecated (no-op) for a transition period, or publishing this change under a new major tag (e.g.,v2) so existing workflows pinned to@v1don't unexpectedly break.
inputs:
checkout_fetch_depth:
description: Depth to fetch repository
required: false
default: '1'
checkout_artifact:
description: Whether to checkout artifact instead of source
required: false
default: 'false'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2b4a0f2 to
273b5ad
Compare
When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it. Not sure we ever needed it.
66e719d to
3f2487b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it