Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the dependency on ServerlessOpsIO/gha-artifact-name by eliminating the artifact naming override/input/output from the composite action, and updates documentation to match the new behavior.
Changes:
- Removed
artifact_name_overrideinput and theSet artifact namestep that usedServerlessOpsIO/gha-artifact-name@v1. - Stopped setting an explicit artifact name for
actions/upload-artifact@v4and removed theartifact-nameoutput. - Updated README to remove artifact naming guidance and reposition the action description around SAM packaging + artifact storage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
action.yaml |
Removes artifact naming input/step/output and no longer sets upload-artifact’s name. |
README.md |
Removes artifact naming docs and updates the action description/inputs/outputs accordingly. |
Comments suppressed due to low confidence (1)
action.yaml:34
if: ${{ inputs.use_aws_sam }}will treat any non-empty string (including the literal "false") as truthy in GitHub Actions expressions. Compare explicitly (e.g.,inputs.use_aws_sam == 'true') or provide a default and usefromJSON()to ensure the SAM packaging step only runs when intended.
- name: Package & Upload SAM artifact
id: package-sam
if: ${{ inputs.use_aws_sam }}
uses: ServerlessOpsIO/gha-package-aws-sam@v1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it. Not sure we ever needed it.
Co-authored-by: Copilot <copilot@github.com>
35fd17d to
40513c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.