Skip to content

deprecate gha-artifact-name#4

Merged
tmclaugh merged 3 commits intomainfrom
feature/deprecate-gha-artifact-name
Apr 23, 2026
Merged

deprecate gha-artifact-name#4
tmclaugh merged 3 commits intomainfrom
feature/deprecate-gha-artifact-name

Conversation

@tmclaugh
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 21:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dependency on ServerlessOpsIO/gha-artifact-name by eliminating the artifact naming override/input/output from the composite action, and updates documentation to match the new behavior.

Changes:

  • Removed artifact_name_override input and the Set artifact name step that used ServerlessOpsIO/gha-artifact-name@v1.
  • Stopped setting an explicit artifact name for actions/upload-artifact@v4 and removed the artifact-name output.
  • Updated README to remove artifact naming guidance and reposition the action description around SAM packaging + artifact storage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
action.yaml Removes artifact naming input/step/output and no longer sets upload-artifact’s name.
README.md Removes artifact naming docs and updates the action description/inputs/outputs accordingly.
Comments suppressed due to low confidence (1)

action.yaml:34

  • if: ${{ inputs.use_aws_sam }} will treat any non-empty string (including the literal "false") as truthy in GitHub Actions expressions. Compare explicitly (e.g., inputs.use_aws_sam == 'true') or provide a default and use fromJSON() to ensure the SAM packaging step only runs when intended.
    - name: Package & Upload SAM artifact
      id: package-sam
      if: ${{ inputs.use_aws_sam }}
      uses: ServerlessOpsIO/gha-package-aws-sam@v1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread action.yaml
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread action.yaml Outdated
Comment thread action.yaml
Comment thread action.yaml
tmclaugh and others added 3 commits April 23, 2026 18:06
When I wrote this initially I was under the belief that runs would overwrite artifacts from previous runs if the name wasn't unique but upon looking at GitHub recently that's not the case. Removing this because we don't need it. Not sure we ever needed it.
Co-authored-by: Copilot <copilot@github.com>
@tmclaugh tmclaugh force-pushed the feature/deprecate-gha-artifact-name branch from 35fd17d to 40513c9 Compare April 23, 2026 22:07
@tmclaugh tmclaugh merged commit ef36941 into main Apr 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants