Conversation
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
…ions Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
📝 WalkthroughWalkthroughThe CI workflow configuration was updated to adjust the linting process by removing a trailing whitespace check step and modifying cppcheck parameters—removing one suppression and adding six new ones while expanding file exclusions to include mp3 files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci-build.yml (1)
70-75: Use file-scoped suppressions instead of repo-wide cppcheck suppressions.These
--suppressflags silence diagnostics for the entire repository, so future findings in maintained code will no longer fail CI. Cppcheck supports file-scoped suppressions with syntax--suppress=<id>:<path/to/file>for individual files or--suppress=<id>:<dir>/**for directories. Apply suppressions only to the files where they are actually needed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci-build.yml around lines 70 - 75, The CI uses repo-wide cppcheck suppressions like --suppress=constVariablePointer, --suppress=constParameterPointer, --suppress=variableScope, --suppress=uselessCallsSubstr, --suppress=useStlAlgorithm, and --suppress=shiftNegativeLHS which silences diagnostics globally; replace these with file-scoped suppressions using cppcheck syntax (--suppress=<id>:<path> or --suppress=<id>:<dir>/**) applied only to the specific files or directories that actually require each suppression (identify offending files via local cppcheck runs and then update the flags to e.g. --suppress=constVariablePointer:relative/path/to/file.cpp or --suppress=useStlAlgorithm:some/dir/** for each relevant suppress id).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci-build.yml:
- Line 76: The CI config currently excludes the mp3 directory from cppcheck by
including "-i mp3" in the ignore list, which removes static analysis from
maintained source files like gen_huff_enc.c; edit the cppcheck invocation in the
workflow (the line containing "-i ggml -i build -i .git -i mp3 \\") to remove
the "-i mp3" token so mp3/ is analyzed, or if exclusion is intentional add a
clear comment explaining why mp3 is safe to skip and reference the specific
files (e.g., gen_huff_enc.c) to justify the exception.
---
Nitpick comments:
In @.github/workflows/ci-build.yml:
- Around line 70-75: The CI uses repo-wide cppcheck suppressions like
--suppress=constVariablePointer, --suppress=constParameterPointer,
--suppress=variableScope, --suppress=uselessCallsSubstr,
--suppress=useStlAlgorithm, and --suppress=shiftNegativeLHS which silences
diagnostics globally; replace these with file-scoped suppressions using cppcheck
syntax (--suppress=<id>:<path> or --suppress=<id>:<dir>/**) applied only to the
specific files or directories that actually require each suppression (identify
offending files via local cppcheck runs and then update the flags to e.g.
--suppress=constVariablePointer:relative/path/to/file.cpp or
--suppress=useStlAlgorithm:some/dir/** for each relevant suppress id).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d28aec8b-696d-4e7e-bcf7-d7f6ef08c09b
⛔ Files ignored due to path filters (3)
tests/CPU-BF16.logis excluded by!**/*.logtests/CPU-Q5_K_M.logis excluded by!**/*.logtests/CPU-Q6_K.logis excluded by!**/*.log
📒 Files selected for processing (1)
.github/workflows/ci-build.yml
This pull request makes adjustments to the CI build workflow to pass the current codng style.
Needs @ServeurpersoCom supervision ACK 😉 Checks should pass
Summary by CodeRabbit