Skip to content

Fix CI formatting issues#23

Closed
lmangani wants to merge 3 commits intoServeurpersoCom:masterfrom
audiohacking:fix-ci-formatting-issues
Closed

Fix CI formatting issues#23
lmangani wants to merge 3 commits intoServeurpersoCom:masterfrom
audiohacking:fix-ci-formatting-issues

Conversation

@lmangani
Copy link
Contributor

@lmangani lmangani commented Mar 12, 2026

This pull request makes adjustments to the CI build workflow to pass the current codng style.
Needs @ServeurpersoCom supervision ACK 😉 Checks should pass

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to adjust code analysis parameters and file exclusions for the linting process.

Copilot AI and others added 3 commits March 12, 2026 08:44
Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
…ions

Co-authored-by: lmangani <1423657+lmangani@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

📝 Walkthrough

Walkthrough

The CI workflow configuration was updated to adjust the linting process by removing a trailing whitespace check step and modifying cppcheck parameters—removing one suppression and adding six new ones while expanding file exclusions to include mp3 files.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci-build.yml
Removed dedicated trailing whitespace check; modified cppcheck suppressions (removed unusedFunction, added constVariablePointer, constParameterPointer, variableScope, uselessCallsSubstr, useStlAlgorithm, shiftNegativeLHS); expanded exclusions to include mp3 files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hop, hop! The workflow's rearranged,
Trailing spaces? Now estranged!
Cppcheck suppressions shuffled with care,
mp3 files skip'd everywhere,
CI pipeline hops along fair!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: adjusting CI workflow configuration (removing trailing whitespace checks and modifying cppcheck suppressions) to fix formatting compliance issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@lmangani lmangani marked this pull request as ready for review March 12, 2026 09:08
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/ci-build.yml (1)

70-75: Use file-scoped suppressions instead of repo-wide cppcheck suppressions.

These --suppress flags silence diagnostics for the entire repository, so future findings in maintained code will no longer fail CI. Cppcheck supports file-scoped suppressions with syntax --suppress=<id>:<path/to/file> for individual files or --suppress=<id>:<dir>/** for directories. Apply suppressions only to the files where they are actually needed.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci-build.yml around lines 70 - 75, The CI uses repo-wide
cppcheck suppressions like --suppress=constVariablePointer,
--suppress=constParameterPointer, --suppress=variableScope,
--suppress=uselessCallsSubstr, --suppress=useStlAlgorithm, and
--suppress=shiftNegativeLHS which silences diagnostics globally; replace these
with file-scoped suppressions using cppcheck syntax (--suppress=<id>:<path> or
--suppress=<id>:<dir>/**) applied only to the specific files or directories that
actually require each suppression (identify offending files via local cppcheck
runs and then update the flags to e.g.
--suppress=constVariablePointer:relative/path/to/file.cpp or
--suppress=useStlAlgorithm:some/dir/** for each relevant suppress id).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci-build.yml:
- Line 76: The CI config currently excludes the mp3 directory from cppcheck by
including "-i mp3" in the ignore list, which removes static analysis from
maintained source files like gen_huff_enc.c; edit the cppcheck invocation in the
workflow (the line containing "-i ggml -i build -i .git -i mp3 \\") to remove
the "-i mp3" token so mp3/ is analyzed, or if exclusion is intentional add a
clear comment explaining why mp3 is safe to skip and reference the specific
files (e.g., gen_huff_enc.c) to justify the exception.

---

Nitpick comments:
In @.github/workflows/ci-build.yml:
- Around line 70-75: The CI uses repo-wide cppcheck suppressions like
--suppress=constVariablePointer, --suppress=constParameterPointer,
--suppress=variableScope, --suppress=uselessCallsSubstr,
--suppress=useStlAlgorithm, and --suppress=shiftNegativeLHS which silences
diagnostics globally; replace these with file-scoped suppressions using cppcheck
syntax (--suppress=<id>:<path> or --suppress=<id>:<dir>/**) applied only to the
specific files or directories that actually require each suppression (identify
offending files via local cppcheck runs and then update the flags to e.g.
--suppress=constVariablePointer:relative/path/to/file.cpp or
--suppress=useStlAlgorithm:some/dir/** for each relevant suppress id).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d28aec8b-696d-4e7e-bcf7-d7f6ef08c09b

📥 Commits

Reviewing files that changed from the base of the PR and between 5865687 and d712970.

⛔ Files ignored due to path filters (3)
  • tests/CPU-BF16.log is excluded by !**/*.log
  • tests/CPU-Q5_K_M.log is excluded by !**/*.log
  • tests/CPU-Q6_K.log is excluded by !**/*.log
📒 Files selected for processing (1)
  • .github/workflows/ci-build.yml

@lmangani lmangani changed the title Fix ci formatting issues Fix CI formatting issues Mar 12, 2026
@lmangani lmangani closed this Mar 12, 2026
@lmangani lmangani deleted the fix-ci-formatting-issues branch March 13, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants