Skip to content

Look entity improvement #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igormukhingmailcom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Look entity improvement #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Model/Look.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ public function getDisplayableDiscount(): float
return $this->getDiscount() * 100;
}

public function setDiscount(float $discount): void
public function setDiscount(?float $discount): void
{
$this->discount = $discount;
$this->discount = $discount ?? 0.0;
}

public function isEnabled(): bool
Expand Down
2 changes: 1 addition & 1 deletion src/Model/LookInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public function getDiscount(): float;

public function getDisplayableDiscount(): float;

public function setDiscount(float $discount): void;
public function setDiscount(?float $discount): void;

public function isEnabled(): bool;

Expand Down