feat: ConfigChanged event — runtime config propagation via EventBus (#622)#634
Merged
feat: ConfigChanged event — runtime config propagation via EventBus (#622)#634
Conversation
…622) - Add ConfigChanged event in modules/core/events.py with key, value, previous_value, namespace fields - ConfigService.set(), set_telegram(), set_widget() now publish ConfigChanged after commit - Audit subscriber in setup_event_subscriptions logs all config changes (action=config_changed) - Graceful fallback: publishing is skipped if EventBus is unavailable (during startup) - 9 unit tests covering event fields, namespace derivation, publish from set(), audit subscriber, idempotency, error isolation Closes #622 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
shikhalev
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigChangedevent inmodules/core/events.py— fields:key,value,previous_value,namespaceConfigService.set(),set_telegram(),set_widget()publishConfigChangedafter DB commitsetup_event_subscriptions()logs all config changes (action=config_changed)widget.colors.primary→widget) for subscriber filteringprevious_valuefetched from DB before write (not from Redis cache) for accuracyDesign decisions
BotConfigUpdated,WidgetConfigUpdated) are better suited for instance-specific changesTest plan
pytest tests/unit/test_config_changed.py)Closes #622
🤖 Generated with Claude Code