Skip to content

Update fake address generator to city of Canton#4

Open
nicoleiocana wants to merge 1 commit intoSharlSherif:masterfrom
nicoleiocana:change-city-in-fakeaddressgenerator
Open

Update fake address generator to city of Canton#4
nicoleiocana wants to merge 1 commit intoSharlSherif:masterfrom
nicoleiocana:change-city-in-fakeaddressgenerator

Conversation

@nicoleiocana
Copy link
Copy Markdown
Collaborator

The const in fakeInfoGenerator now contains a URL to the city of Canton, OH.

@SharlSherif
Copy link
Copy Markdown
Owner

Hello, does this still work?

@nicoleiocana
Copy link
Copy Markdown
Collaborator Author

Yes, but crucial changes must be made along with using the Stark library. I have just confirmed that fake email addresses no longer work.

signin

@SharlSherif
Copy link
Copy Markdown
Owner

So we need a real email address? should I use your PR and add a way for users to input their email addresses?

@nicoleiocana
Copy link
Copy Markdown
Collaborator Author

Yes. I made alternative accounts to test the variables. The accounts that have failed are:

  1. those that used a fake email address listed from the fake address generator website
  2. those that used the fake address from the fake address generator website

@SharlSherif
Copy link
Copy Markdown
Owner

We can just let users use their real emails and verify the account. not a big issue.

@nicoleiocana
Copy link
Copy Markdown
Collaborator Author

nicoleiocana commented Jan 21, 2020

Agreed. The new address must come from this website:

https://www.zillow.com/homes/for_sale/Canton-OH/pmf,pf_pt/51260_rid/globalrelevanceex_sort/40.970307,-81.148453,40.68246,-81.617432_rect/10_zm/

Your js code will now need two constants: one for the first name, last name, birthday. And another one for the Canton, OH address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants