Update fake address generator to city of Canton#4
Open
nicoleiocana wants to merge 1 commit intoSharlSherif:masterfrom
Open
Update fake address generator to city of Canton#4nicoleiocana wants to merge 1 commit intoSharlSherif:masterfrom
nicoleiocana wants to merge 1 commit intoSharlSherif:masterfrom
Conversation
Owner
|
Hello, does this still work? |
Collaborator
Author
Owner
|
So we need a real email address? should I use your PR and add a way for users to input their email addresses? |
Collaborator
Author
|
Yes. I made alternative accounts to test the variables. The accounts that have failed are:
|
Owner
|
We can just let users use their real emails and verify the account. not a big issue. |
Collaborator
Author
|
Agreed. The new address must come from this website: Your js code will now need two constants: one for the first name, last name, birthday. And another one for the Canton, OH address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The const in fakeInfoGenerator now contains a URL to the city of Canton, OH.