Implement base type and interface validation fallback for Minimal APIs#84
Open
bernardbr wants to merge 9 commits intoSharpGrip:masterfrom
Open
Implement base type and interface validation fallback for Minimal APIs#84bernardbr wants to merge 9 commits intoSharpGrip:masterfrom
bernardbr wants to merge 9 commits intoSharpGrip:masterfrom
Conversation
…ration on GetValidator method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello to all contributors and maintainers. I would like to thank you for the great work being done on this project.
Motivation and Context
The current automatic validation pipeline rigidly resolves validators by looking for the exact type of the endpoint parameter. This prevents the validation of DTOs implementing interfaces or inheriting from base classes when the validator is defined for the abstraction.
This PR introduces the
WithBaseTypeValidationssetting, enabling the lookup engine to traverse the type hierarchy if a specific validator for the concrete type is not found. This enhancement will be essential for utilizing this library in an important, large-scale project I am currently working on.Changes Made
UseBaseTypeValidationsflag and theWithBaseTypeValidations()fluent method.GetValidatormethod now performs a recursive search ordered by: Concrete Type, Base Classes, and Interfaces.ActionFilter.Benefits