Skip to content

1604 add covid jobs and covid financial categories#539

Open
meltingmelon wants to merge 9 commits into
masterfrom
1604-add-covid-jobs-and-covid-financial-categories
Open

1604 add covid jobs and covid financial categories#539
meltingmelon wants to merge 9 commits into
masterfrom
1604-add-covid-jobs-and-covid-financial-categories

Conversation

@meltingmelon

@meltingmelon meltingmelon commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

Ran SQL script on staging to add new Covid-jobs category and modify Covid-finances category to match with new hierarchy, Added Covid Jobs and Covid Finances to db populate script in local dev.

@jjfreund jjfreund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing -- if you could separate your changes into another file that would be helpful, as we're not going to rerun the entirety of the script. Also please add each service to the parent category as well, that's required for search to work properly.

Comment thread db/sql/add-covid-categories.sql Outdated


-- Covid Finance Category and Subcategories
delete from category_relationships(parent_id,child_id) values (1000003,1100010);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete from category_relationships where parent_id=1000003 and child_id=1100010;

@meltingmelon
meltingmelon requested a review from jjfreund October 5, 2020 00:44
Comment thread db/sql/covid-jobs-and-finance.sql Outdated

-- Covid Finance Category and Subcategories
delete from category_relationships(parent_id,child_id) where parent_id=1000003 and child_id=1100010;
delete from category_services where category_id=1000003 and service_id=1070

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table name is categories_services, and you are missing a semicolon.

@meltingmelon
meltingmelon requested a review from jjfreund October 5, 2020 01:53

@jjfreund jjfreund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread db/sql/covid-shelter.sql Outdated
(1000009, '04-OCT-20', '04-OCT-20', 'Covid-shelter', 't', null, 'f');

insert into categories (id, created_at, updated_at, name, top_level, vocabulary, featured) values
(1100035, '04-OCT-20', '04-OCT-20', 'Job Boa', 'f', null, 'f'); No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a newline at the end of the file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also why don't you pull out the shelter stuff until it's complete so I can merge the rest in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh did this not get removed from this branch? I'm looking at db/sql/ and I don't still see it...

@jjfreund jjfreund left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants