Skip to content

🏷️ types: move to ty#47

Merged
SigureMo merged 1 commit into
mainfrom
copilot/move-to-ty
Apr 25, 2026
Merged

🏷️ types: move to ty#47
SigureMo merged 1 commit into
mainfrom
copilot/move-to-ty

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 25, 2026

  • Inspect the repo, referenced ty migration PRs, and current lint/typecheck setup
  • Replace pyright with ty in project config, editor recommendations, and docs
  • Update code/tests for ty compatibility and refresh the lockfile
  • Run local lint, tests, and build validation to ensure CI passes
  • Run final review/security validation and prepare the PR

Agent-Logs-Url: https://github.com/ShigureLab/gh-llm/sessions/c46c5b23-f6ea-4f36-a13f-b30208896afb

Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
@SigureMo SigureMo marked this pull request as ready for review April 25, 2026 18:09
Copilot AI review requested due to automatic review settings April 25, 2026 18:09
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project’s Python type-checking workflow from pyright to ty, updating dev dependencies and developer tooling to keep lint/typecheck in sync with the new checker.

Changes:

  • Replace pyright with ty in dev dependencies (pyproject.toml) and lockfile (uv.lock).
  • Update lint commands/documentation to run ty check (Justfile + README).
  • Remove pyright-specific ignore comments in tests and adjust a local variable annotation for type-checker compatibility.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Removes pyright/nodeenv and adds locked ty distribution metadata.
pyproject.toml Swaps dev dependency from pyright to ty, removes [tool.pyright], and tightens Ruff by no longer ignoring F401/F841.
justfile Updates lint target to run ty check --error-on-warning before Ruff.
README.md Updates development instructions to use ty instead of pyright.
.vscode/extensions.json Updates VS Code extension recommendations to prefer the ty extension over Pylance.
tests/test_cli.py Removes pyright private-usage ignore comments.
src/gh_llm/pr_body.py Adds an explicit type annotation for blocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .vscode/extensions.json
@@ -1,7 +1,7 @@
{
"recommendations": [
"ms-python.python",
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the Pylance extension recommendation, but the repo’s VS Code settings still use python.analysis.* inlay hint settings (provided by Pylance). Either keep recommending ms-python.vscode-pylance, or update/remove those settings (and document the ty extension configuration) so the recommended extension set matches the workspace settings.

Suggested change
"ms-python.python",
"ms-python.python",
"ms-python.vscode-pylance",

Copilot uses AI. Check for mistakes.
@SigureMo SigureMo merged commit 3ff182c into main Apr 25, 2026
6 checks passed
@SigureMo SigureMo deleted the copilot/move-to-ty branch April 25, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants