🎨 Palette: Add keyboard shortcuts to primary action#118
Conversation
- Adds `aria-keyshortcuts="Control+k Meta+k"` to the accessible action button. - Replaces standard loading reset with `childNodes` preservation and `replaceChildren` to safeguard nested `<kbd>` tags. - Attaches global keydown event listener to safely catch `Ctrl+K` and `Cmd+K`, set programmatic focus, and fire the click event. - Adds new Palette learning to `.jules/palette.md` covering DOM node preservation techniques to safeguard layout without triggering XSS risks. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Added a standard
Ctrl+K/Cmd+Kkeyboard shortcut to the primary sample button, allowing immediate non-pointer interaction without layout interruption. Enhanced state saving logic to gracefully preserve complex button childNodes, circumventing XSS-prone innerHTML overrides.🎯 Why:
Keyboard shortcuts represent a micro-UX enhancement that creates an immediately satisfying and "pro" feel for standard operations. It reduces friction for rapid task completion and provides a complementary navigation mechanism for all users. The refactor of state preservation sets a great precedent for future components scaling with nested DOM content.
📸 Before/After:
Before: Button read "Click Me (Accessible)"
After: Button reads "Click Me Ctrl+K" natively preserving structure when swapping loading spinner state.
♿ Accessibility:
The button properly exposes the new keystroke logic through the
aria-keyshortcuts="Control+k Meta+k"attribute, enabling assistive technologies to discover the shortcut. Programmatic focus management allows screen readers to remain fully aware of the user's execution context.Also updated
.jules/palette.mdto persist learnings regarding safe layout updates without sacrificing security standards.PR created automatically by Jules for task 6807554731042087188 started by @Shin5hi