Skip to content

🎨 Palette: Add keyboard shortcuts with visual hints#123

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette/add-keyboard-shortcut-18029664910573799579
Draft

🎨 Palette: Add keyboard shortcuts with visual hints#123
Shin5hi wants to merge 1 commit into
mainfrom
palette/add-keyboard-shortcut-18029664910573799579

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 11, 2026

Copy link
Copy Markdown
Owner

💡 What

Added a global keyboard shortcut (⌘K / Ctrl+K) to trigger the primary action button, along with a visual <kbd> hint and aria-keyshortcuts attribute. Refactored state preservation to safely keep nested elements in the DOM instead of overwriting with textContent.

🎯 Why

Keyboard shortcuts allow power users and keyboard-reliant users to interact with key functionality much more quickly without needing to manually tab to the button or use a mouse. The visual hint helps discoverability.

📸 Before/After

Before: The button simply said "Click Me (Accessible)" and required manual focus/clicking.
After: The button includes the <kbd>⌘K</kbd> text, and pressing Meta+K/Ctrl+K will immediately focus and trigger the loading state on the button.

♿ Accessibility

Added the aria-keyshortcuts="Control+K Meta+K" attribute to explicitly inform assistive technologies of the available shortcut. Programmatically focusing the button ensures keyboard users' focus state is smoothly tracked when they use the shortcut. Maintained XSS safety by avoiding innerHTML.


PR created automatically by Jules for task 18029664910573799579 started by @Shin5hi

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df04100f-12fc-4230-a9d8-379e93d0868f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/add-keyboard-shortcut-18029664910573799579

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant