Skip to content

🎨 Palette: Add keyboard shortcut hints to action button#125

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-10549548407696732323
Draft

🎨 Palette: Add keyboard shortcut hints to action button#125
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-10549548407696732323

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 12, 2026

Copy link
Copy Markdown
Owner

💡 What:
Added global keyboard shortcut (Ctrl+Enter or Meta+Enter) to trigger the primary action button. Visually added <kbd> hints directly into the button text to surface the shortcut to the user. Updated state restoration mechanics (using node preservation over textContent) to protect structural <kbd> UI hints during the button's loading state.

🎯 Why:
Power users and keyboard navigators expect standard interaction paths to be faster. Showing the shortcut visually and reacting to it anywhere on the page provides an intuitive micro-UX efficiency boost.

📸 Before/After:
Before: The button only read Click Me (Accessible). Users had to physically tab to it or click it to initiate.
After: The button displays Click Me (Accessible) Ctrl+Enter using standard browser styling for <kbd>, and pressing Ctrl+Enter globally triggers it while maintaining focus.

♿ Accessibility:

  • Added aria-keyshortcuts="Control+Enter Meta+Enter" to the button for screen reader awareness.
  • Forced .focus() onto the button when triggered via shortcut to visibly update the tab navigation state to the user.
  • Utilized Array.from(element.childNodes) and replaceChildren to safely preserve visual <kbd> elements without relying on innerHTML exposing XSS vectors.

PR created automatically by Jules for task 10549548407696732323 started by @Shin5hi

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a3d18355-1d26-41de-8cad-351419df17d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-keyboard-shortcuts-10549548407696732323

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant