🎨 Palette: Add keyboard shortcut hints to action button#125
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Added global keyboard shortcut (
Ctrl+EnterorMeta+Enter) to trigger the primary action button. Visually added<kbd>hints directly into the button text to surface the shortcut to the user. Updated state restoration mechanics (using node preservation over textContent) to protect structural<kbd>UI hints during the button's loading state.🎯 Why:
Power users and keyboard navigators expect standard interaction paths to be faster. Showing the shortcut visually and reacting to it anywhere on the page provides an intuitive micro-UX efficiency boost.
📸 Before/After:
Before: The button only read
Click Me (Accessible). Users had to physically tab to it or click it to initiate.After: The button displays
Click Me (Accessible) Ctrl+Enterusing standard browser styling for<kbd>, and pressingCtrl+Enterglobally triggers it while maintaining focus.♿ Accessibility:
aria-keyshortcuts="Control+Enter Meta+Enter"to the button for screen reader awareness..focus()onto the button when triggered via shortcut to visibly update the tab navigation state to the user.Array.from(element.childNodes)andreplaceChildrento safely preserve visual<kbd>elements without relying oninnerHTMLexposing XSS vectors.PR created automatically by Jules for task 10549548407696732323 started by @Shin5hi