🎨 Palette: Add keyboard shortcut and hints to main action button#127
🎨 Palette: Add keyboard shortcut and hints to main action button#127Shin5hi wants to merge 1 commit into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added a global keyboard shortcut (Ctrl/Cmd + Enter) to trigger the primary action button and visually indicated the shortcut using
<kbd>tags. Refactored the loading state logic to preserve nested DOM nodes instead of overwriting.textContent. Updated CSP hash to reflect changes.🎯 Why: Enhances power-user experience and accessibility by allowing users to complete the primary form action without reaching for their mouse.
📸 Before/After: Before, the button said "Click Me (Accessible)" without shortcut bindings. Now, it displays "Click Me Ctrl/Cmd + Enter" with functional cross-platform bindings.
♿ Accessibility: Added
aria-keyshortcuts="Control+Enter Meta+Enter"to the button so screen readers correctly broadcast the availability of the shortcut to assistive tech users.PR created automatically by Jules for task 3433610020540615552 started by @Shin5hi