Skip to content

🎨 Palette: Add keyboard shortcuts#130

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-7474417526531737678
Draft

🎨 Palette: Add keyboard shortcuts#130
Shin5hi wants to merge 1 commit into
mainfrom
palette-keyboard-shortcuts-7474417526531737678

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 14, 2026

Copy link
Copy Markdown
Owner

💡 What

Added a keyboard shortcut (Ctrl+Enter or Cmd+Enter) to trigger the primary action button. This includes visual <kbd> hints directly on the button and cross-platform keydown event handling.

🎯 Why

Keyboard shortcuts significantly improve usability for power users and keyboard navigators, making repetitive tasks faster and more intuitive without needing to manually focus the button first.

📸 Before/After

Before: Button simply read "Click Me (Accessible)" with no keyboard shortcut beyond basic tabbing.
After: Button reads "Click Me (Accessible) Ctrl+Enter", and pressing those keys programmatically focuses and clicks the button.

♿ Accessibility

  • Added aria-keyshortcuts="Control+Enter Meta+Enter" to the button to explicitly communicate the shortcut to assistive technologies.
  • Preserved DOM structure during loading states using replaceChildren to ensure the semantic <kbd> tags are correctly maintained and not stripped into plain text.
  • Ensured the keydown listener programmatically calls .focus() before .click() so keyboard users maintain clear focus context.

PR created automatically by Jules for task 7474417526531737678 started by @Shin5hi

- Added `aria-keyshortcuts="Control+Enter Meta+Enter"`
- Added visual `<kbd>` hints
- Added cross-platform document keydown listener
- Refactored DOM state saving to preserve HTML tags
- Updated CSP hash

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18551faa-03ab-4611-b4aa-f9f30ff010d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-keyboard-shortcuts-7474417526531737678

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant