🎨 Palette: Add keyboard shortcuts#130
Conversation
- Added `aria-keyshortcuts="Control+Enter Meta+Enter"` - Added visual `<kbd>` hints - Added cross-platform document keydown listener - Refactored DOM state saving to preserve HTML tags - Updated CSP hash Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What
Added a keyboard shortcut (
Ctrl+EnterorCmd+Enter) to trigger the primary action button. This includes visual<kbd>hints directly on the button and cross-platform keydown event handling.🎯 Why
Keyboard shortcuts significantly improve usability for power users and keyboard navigators, making repetitive tasks faster and more intuitive without needing to manually focus the button first.
📸 Before/After
Before: Button simply read "Click Me (Accessible)" with no keyboard shortcut beyond basic tabbing.
After: Button reads "Click Me (Accessible)
Ctrl+Enter", and pressing those keys programmatically focuses and clicks the button.♿ Accessibility
aria-keyshortcuts="Control+Enter Meta+Enter"to the button to explicitly communicate the shortcut to assistive technologies.replaceChildrento ensure the semantic<kbd>tags are correctly maintained and not stripped into plain text.keydownlistener programmatically calls.focus()before.click()so keyboard users maintain clear focus context.PR created automatically by Jules for task 7474417526531737678 started by @Shin5hi