Skip to content

🎨 Palette: Add keyboard shortcut hint to action button#132

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette/add-keyboard-shortcut-12045119918194339082
Draft

🎨 Palette: Add keyboard shortcut hint to action button#132
Shin5hi wants to merge 1 commit into
mainfrom
palette/add-keyboard-shortcut-12045119918194339082

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 15, 2026

Copy link
Copy Markdown
Owner

💡 What:
Added a Cmd/Ctrl + K keyboard shortcut to trigger the main action button. Added a visual <kbd> element inside the button to hint at this shortcut. Modified the state transition logic to save and restore the DOM node structure natively rather than wiping the text content, safely keeping the button label intact. Added the shortcut to aria-keyshortcuts for assistive technologies.

🎯 Why:
Enables faster operation for keyboard users and power users without forcing them to manually tab or mouse to the primary action button.

📸 Before/After:

  • Before: Button just read "Click Me (Accessible)", user had to click or tab to it.
  • After: Button reads "Click Me ⌘K". Pressing Cmd/Ctrl + K safely focuses the button and executes the click handler, displaying the loading sequence while preserving the nested <kbd> tag.

Accessibility:

  • Included the aria-keyshortcuts="Control+K Meta+K" attribute so screen readers announce the shortcut correctly.
  • Ensured that when the shortcut is triggered, focus is brought immediately to the button via actionBtn.focus().
  • Implemented state preservation using replaceChildren(...) instead of innerHTML to eliminate XSS risks while preserving the <kbd> structure.

PR created automatically by Jules for task 12045119918194339082 started by @Shin5hi

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce20a782-4927-4a66-a26d-4332c39239d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/add-keyboard-shortcut-12045119918194339082

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant