🎨 Palette: Add keyboard shortcut hint to action button#132
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
Added a
Cmd/Ctrl + Kkeyboard shortcut to trigger the main action button. Added a visual<kbd>element inside the button to hint at this shortcut. Modified the state transition logic to save and restore the DOM node structure natively rather than wiping the text content, safely keeping the button label intact. Added the shortcut toaria-keyshortcutsfor assistive technologies.🎯 Why:
Enables faster operation for keyboard users and power users without forcing them to manually tab or mouse to the primary action button.
📸 Before/After:
Cmd/Ctrl + Ksafely focuses the button and executes the click handler, displaying the loading sequence while preserving the nested<kbd>tag.♿ Accessibility:
aria-keyshortcuts="Control+K Meta+K"attribute so screen readers announce the shortcut correctly.actionBtn.focus().replaceChildren(...)instead ofinnerHTMLto eliminate XSS risks while preserving the<kbd>structure.PR created automatically by Jules for task 12045119918194339082 started by @Shin5hi