Skip to content

🎨 Palette: Add keyboard shortcuts to action button#136

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette-add-keyboard-shortcut-1431195435719655098
Draft

🎨 Palette: Add keyboard shortcuts to action button#136
Shin5hi wants to merge 1 commit into
mainfrom
palette-add-keyboard-shortcut-1431195435719655098

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 17, 2026

Copy link
Copy Markdown
Owner

💡 What

Added a keyboard shortcut (Ctrl+Enter or Meta+Enter) to trigger the main accessible action button. Added <kbd> visual hints directly into the button text, and registered a global keyboard listener that properly focuses and clicks the button. Refactored the loading state script to use childNodes and replaceChildren to ensure the nested <kbd> elements are preserved during the loading phase.

🎯 Why

Keyboard shortcuts dramatically improve the UX for power users and keyboard navigators, making the interface feel more responsive and intuitive to interact with without requiring a mouse click.

📸 Before/After

Before: Button read Click Me (Accessible) and required clicking or tabbing and pressing Enter.
After: Button reads Click Me (Ctrl+Enter) and can be triggered anywhere on the page using the shortcut.

♿ Accessibility

  • Added aria-keyshortcuts="Control+Enter Meta+Enter" to the button so screen readers can announce the shortcut.
  • The global listener calls actionBtn.focus() before clicking, ensuring focus management is preserved and visual focus indicators (outline) trigger, giving the user feedback that the shortcut worked.
  • Maintained security by strictly avoiding innerHTML when preserving the nested <kbd> tags.

PR created automatically by Jules for task 1431195435719655098 started by @Shin5hi

Added a keyboard shortcut (Ctrl+Enter / Cmd+Enter) to trigger the main accessible button, complete with visual `<kbd>` hints and ARIA support. Also refactored the loading state to preserve HTML structure safely.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e8c31b17-f0a1-41e2-9e0c-029db3e06c23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-add-keyboard-shortcut-1431195435719655098

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant