Skip to content

🎨 Palette: Add keyboard shortcut hint to action button#140

Draft
Shin5hi wants to merge 1 commit into
mainfrom
palette-add-keyboard-shortcut-1160012210817010914
Draft

🎨 Palette: Add keyboard shortcut hint to action button#140
Shin5hi wants to merge 1 commit into
mainfrom
palette-add-keyboard-shortcut-1160012210817010914

Conversation

@Shin5hi

@Shin5hi Shin5hi commented Apr 19, 2026

Copy link
Copy Markdown
Owner

💡 What:

  • Added a Ctrl+Enter / Cmd+Enter keyboard shortcut to trigger the #action-btn.
  • Added an aria-keyshortcuts attribute indicating the shortcut.
  • Added a visual <kbd> hint inside the button text.
  • Refactored the button's loading/restoration state logic to cache and restore childNodes using replaceChildren(), preserving the nested <kbd> HTML structure instead of destroying it with textContent.
  • Updated the CSP hash for the modified inline script.
  • Documented the learning about preserving DOM structure in .jules/palette.md.

🎯 Why:
Power users expect keyboard shortcuts to speed up common actions without leaving their current workflow. Visual hints make these shortcuts discoverable, while avoiding innerHTML or textContent manipulation during loading states prevents XSS risks and UI degradation.

📸 Before/After:
(Visual changes verified via Playwright screenshot; button now clearly shows <kbd>Ctrl+Enter</kbd>)

Accessibility:

  • Follows cross-platform conventions (e.ctrlKey || e.metaKey).
  • Explicitly announces the shortcut to screen readers via aria-keyshortcuts="Control+Enter Meta+Enter".
  • Uses semantic <kbd> tags for visual styling.

PR created automatically by Jules for task 1160012210817010914 started by @Shin5hi

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cedd2340-e76d-4e81-bf28-586f1b40d035

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-add-keyboard-shortcut-1160012210817010914

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant