🎨 Palette: Keyboard Shortcuts#142
Conversation
- Adds visual `<kbd>` hint and `aria-keyshortcuts` to the action button - Implements global Ctrl/Cmd+Enter keyboard shortcut listener - Fixes state restoration to use `replaceChildren` instead of `textContent` to preserve nested HTML elements - Updates CSP SHA-256 hash - Documents findings in `.jules/palette.md` Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added cross-platform (Ctrl/Cmd + Enter) keyboard shortcuts to the primary action button, visually indicated with a
<kbd>tag and semantically viaaria-keyshortcuts. The button's state restoration logic was refactored to usereplaceChildren()to prevent stripping the nested structural tags upon completing the mock async operation.🎯 Why: Power users rely on keyboard navigation. Providing clear shortcuts reduces friction and time-to-action without requiring a mouse. Preserving the DOM structure during loading states ensures the visual hint isn't permanently lost after the first interaction.
📸 Before/After: The button text changed from
Click Me (Accessible)toClick Me <kbd>Ctrl+Enter</kbd>, and pressing the keyboard shortcut triggers the UI loading flow exactly like a mouse click.♿ Accessibility: Exposed the new functionality via
aria-keyshortcutsso screen readers are aware of the alternate interaction method, and safely avoided XSS risks by usingreplaceChildren()instead ofinnerHTML.PR created automatically by Jules for task 14939107498592242138 started by @Shin5hi