fix: automated secret resolution at runtime for inputs and parameters #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runtime - updated frontend secret editor to save secret.id instead of name - removed manual mode from secret editor to simplify contract - updated activity input to include inputOverrides and rawParams - implemented runtime secret resolution in runComponentActivity - ensured secret resolution only happens for ports marked as 'secret' type or editor Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
- implement automatic secret resolution for input overrides and parameters in runComponentActivity - ensure dynamic ports are resolved before secret resolution - update e2e tests to verify secret flow using script echo pattern - mask secret-type ports in node-io outputs - remove unused _secretMode in ParameterField.tsx Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Created a reusable LeanSelect component with search, inline clearing, and accessibility improvements. - Refactored SecretSelect to use LeanSelect and enabled clearing by default. - Integrated LeanSelect into ParameterField for consistent parameter editing. - Improved WorkflowNode to resolve secret UUIDs to human-readable names. - Enhanced manual input UI on nodes with descriptive labels and icons. - Added validation for missing secrets. Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes secret resolution across the platform, addressing issues where secret IDs were being passed to components instead of their resolved values.
Key Changes
Fixes ENG-116
Fixes ENG-120