Fix E2E Test Failures & Trace Summaries #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated E2E tests to use the correct nested 'params' structure for Entry Point and HTTP Request components. - Fixed 'workflows.service.ts' to correctly extract parameters for dynamic port resolution from config.params. - Added detailed error reporting in 'http-observability.test.ts' for failed workflow creation. Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
Previously, 'createLightweightSummary' ignored primitive values (numbers, strings, booleans), causing trace outputs to appear empty or truncated in E2E tests and the UI. This fix ensures primitives are correctly copied to the summary. Signed-off-by: betterclever <paliwal.pranjal83@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses critical failures in E2E tests and fixes trace summary generation for primitive values.
Changes
Worker Trace Summary Fix (`worker/src/temporal/utils/component-output.ts`):
Backend Dynamic Port Resolution (`backend/src/workflows/workflows.service.ts`):
E2E Test Updates:
Impact