Skip to content

Various fixes for first working version#5

Closed
bob2021 wants to merge 22 commits intoShipStream:mainfrom
bob2021:improve-merged-schemas
Closed

Various fixes for first working version#5
bob2021 wants to merge 22 commits intoShipStream:mainfrom
bob2021:improve-merged-schemas

Conversation

@bob2021
Copy link
Copy Markdown
Collaborator

@bob2021 bob2021 commented Aug 8, 2025

This MR contains all the fixes required for ShipStream's FedEx integration. It depends on highsidelabs/saloon-sdk-generator#10 being merged, in the meantime it points to my branch.

  • Changed merging of similar schemas to only merge when all the property names and types are the same (fixes DTO objects from merged schemas having property types that are not compatible with all use cases)
  • When similar schemas are merged, a property is only required if every merged schema required it (fixes DTO objects from merged schemas requiring a property in a context where it is not required)
  • Fix Trade Documents Upload API (FedEx schema is incorrect, multipart/form content type throws error in saloon-sdk-generator)
  • Added Account Registration API and Ship DG Hazmat API
  • Updated all schemas except Global Trade, which is throwing an error on generation for some reason.

@colinmollenhour
Copy link
Copy Markdown
Contributor

Looks excellent! Is this still in draft? Seems the test action is failing.

I'd like to wait a bit and see if we can get that dependent PR merged so we don't have to launch on a fork..

@bob2021 bob2021 marked this pull request as draft August 12, 2025 08:03
@bob2021
Copy link
Copy Markdown
Collaborator Author

bob2021 commented Aug 12, 2025

The test action is failing due to missing environment variables for client_key and client_secret. I think it will probably pass if someone with write access to the target repo runs the action. I'm happy to leave it in draft until the FedEx integration is complete and I know there are no more changes required.

@colinmollenhour
Copy link
Copy Markdown
Contributor

The test action is failing due to missing environment variables for client_key and client_secret. I think it will probably pass if someone with write access to the target repo runs the action. I'm happy to leave it in draft until the FedEx integration is complete and I know there are no more changes required.

Just FYI I added you directly to the repo as maintainer so hopefully that'll fix the GH Actions.

@colinmollenhour
Copy link
Copy Markdown
Contributor

It seems to still not get the secrets even if I trigger it. Perhaps you have to push the branch to the ShipStream repo instead of your private repo?

@bob2021
Copy link
Copy Markdown
Collaborator Author

bob2021 commented Sep 5, 2025

I pushed my branch to the ShipStream repo and opened #6

@bob2021 bob2021 closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants