Various fixes for first working version#5
Conversation
|
Looks excellent! Is this still in draft? Seems the test action is failing. I'd like to wait a bit and see if we can get that dependent PR merged so we don't have to launch on a fork.. |
|
The test action is failing due to missing environment variables for client_key and client_secret. I think it will probably pass if someone with write access to the target repo runs the action. I'm happy to leave it in draft until the FedEx integration is complete and I know there are no more changes required. |
Just FYI I added you directly to the repo as maintainer so hopefully that'll fix the GH Actions. |
|
It seems to still not get the secrets even if I trigger it. Perhaps you have to push the branch to the ShipStream repo instead of your private repo? |
|
I pushed my branch to the ShipStream repo and opened #6 |
This MR contains all the fixes required for ShipStream's FedEx integration.
It depends on highsidelabs/saloon-sdk-generator#10 being merged, in the meantime it points to my branch.