feat: migrate is-function utility to TypeScript and fix iframe tests#928
Draft
feat: migrate is-function utility to TypeScript and fix iframe tests#928
Conversation
- Convert src/utils/is-function.js to TypeScript with proper type annotations - Configure ESLint to resolve .ts file extensions for imports - Update browserify/babelify configuration to handle .ts files in tests - Configure testem to run tests in headless Chrome mode - Fix 6 iframe accessibility tests to work with ES6 modules by testing DOM attributes directly - Update task documentation with learnings about test configuration and ES6 module constraints
- Document test philosophy: never skip tests, always refactor for constraints - Add Git operations best practices for file renames during JS→TS conversion - Detail configuration requirements and order for TypeScript setup - Document test system quirks and specific syntax requirements - Establish clear migration pattern for future utility conversions - List common pitfalls to avoid based on encountered issues - Note that ESLint and browserify configs are now ready for remaining utilities
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: migrate is-function utility to TypeScript and fix iframe tests
docs: add comprehensive learnings from TypeScript migration work