Open
Conversation
max611
approved these changes
Feb 16, 2026
kdaviduik
requested changes
Feb 16, 2026
kdaviduik
requested changes
Feb 16, 2026
| @@ -1,5 +1,7 @@ | |||
| function getUnitString(unitEnum) { | |||
| if(unitEnum === 'L') { | |||
| if (!unitEnum) return ''; | |||
Contributor
There was a problem hiding this comment.
Fixing the issue purely at this level returns an empty string, causing the template to render "$10.00 /" (price with trailing slash, no unit). This looks broken.
Imo we should add in a check for this inside of showUnitPrice
get showUnitPrice() {
if (!this.selectedVariant ||
!this.selectedVariant.unitPrice ||
!this.options.contents.unitPrice) {
return false;
}
// Add this validation
const measurement = this.selectedVariant.unitPriceMeasurement;
if (!measurement || !measurement.referenceUnit) {
return false;
}
return true;
}Also this change needs tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Closes https://github.com/shop/issues-headless/issues/1281
Added handling for null or undefined unit values in the
getUnitStringfunction.Inital Error
TypeError: Cannot read properties of null (reading 'toLowerCase')Why make this change?
When a product variant has unitPrice but its unitPriceMeasurement.referenceUnit is null, getUnitString() calls .toLowerCase() on null, crashing the render. This cascading failure then causes a secondary error when downstream code accesses .cart on the undefined result of the failed component initialization.