feat(react-native): use local android/swift project references by kieran-osgood-shopify · Pull Request #115 · Shopify/checkout-kit

kieran-osgood-shopify · 2026-05-14T15:34:36Z

What changes are you making?

Adds a --local flag to the react native ios and android commands

local defaults to false, meaning you will point to the production builds, currently this will fail as we dont have production builds on the new checkout-kit namespace, so to run the app you'll typically want --local

Usage:
dev rn android --local
dev rn ios --local

This will configure the native code to point to the local platforms/ios/ and platforms/android` directory, instead of the published maven and cocoapods versions.

This enables a local development feedback loop without waiting for publishes for react native.

How to test

Before you merge

Important

I've added tests to support my implementation
I have read and agree with the Contribution Guidelines
I have read and agree with the Code of Conduct
I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?

I have bumped the version in ShopifyCheckoutKit.podspec
I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
I have updated platforms/swift/CHANGELOG.md
I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)

Releasing a new Android version?

I have bumped the versionName in platforms/android/lib/build.gradle
I have updated platforms/android/CHANGELOG.md
I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kieran-osgood-shopify · 2026-05-14T15:34:56Z

feat(react-native): use local android/swift project references #115 : 2 dependent PRs (#116 , #119 ) 👈 (View in Graphite)
feat(protocol): add typescript interfaces #114
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2026-05-14T15:35:23Z

React Native — Coverage Report

Lines	Statements	Branches	Functions
	95.52% (192/201)	92.3% (108/117)	100% (60/60)

kieran-osgood-shopify · 2026-05-14T19:17:27Z


+def useLocalSdk = (System.getenv("USE_LOCAL_SDK") ?: "0") == "1"
+def shopifySdkArtifact = useLocalSdk
+  ? "com.shopify:checkout-kit:1.0.0"


this version doesn't matter as its just using local so it accepts anything

tiagocandido

Review assisted by pair-review

tiagocandido · 2026-05-15T16:38:43Z

+
+### CI
+
+CI uses the default (published) path naturally — no special flag handling. As defense-in-depth, the build wiring still ignores `USE_LOCAL_SDK=1` when the `CI` env var is set (GitHub Actions sets `CI=true` automatically).


The docs say CI naturally stays on the published path and ignores USE_LOCAL_SDK when CI=true, but the workflows added in this PR set USE_LOCAL_SDK=1 globally and the Podfile, podspec, Gradle files, and helper scripts do not check CI before honoring it. As written, this section gives reviewers and contributors the wrong model for how RN CI is currently working.

Suggestion:

Suggested change

CI uses the default (published) path naturally — no special flag handling. As defense-in-depth, the build wiring still ignores `USE_LOCAL_SDK=1` when the `CI` env var is set (GitHub Actions sets `CI=true` automatically).

CI currently sets `USE_LOCAL_SDK=1` so the sample and module build against the in-repo Swift and Android SDKs until the renamed `ShopifyCheckoutKit` artifacts are published to CocoaPods trunk and Maven Central.

tiagocandido · 2026-05-15T16:38:44Z


+allprojects {
+    repositories {
+        mavenLocal()


This PR describes local SDK resolution as opt-in, but mavenLocal() is now inserted ahead of remote repositories in the sample build and the RN module Gradle file. In the non-local path both consumers still request com.shopify:checkout-sheet-kit:3.5.3, so any matching artifact already in ~/.m2 will win before Gradle reaches Maven Central. That makes a plain non---local build depend on contributor machine state instead of reliably exercising the published path.

Suggestion: Consider gating mavenLocal() behind the same USE_LOCAL_SDK switch in both Android Gradle files, or at minimum restricting it with repository content filters so only explicit local-mode builds can resolve Shopify SDK artifacts from ~/.m2.

tiagocandido · 2026-05-15T16:38:44Z

+  fi
+done
+
+if [ "$use_local" = "1" ]; then


🐛 Bug: The new iOS flow only re-resolves CocoaPods when --local is present, but the rest of the wiring treats USE_LOCAL_SDK as the underlying switch. That means USE_LOCAL_SDK=1 dev rn ios can keep using whatever pods were previously resolved instead of switching to the local ShopifyCheckoutKit pod, which makes the documented env-driven path unreliable on iOS.

Suggestion:

Suggested change

if [ "$use_local" = "1" ]; then

if [ "$use_local" = "1" ] || [ "${USE_LOCAL_SDK:-0}" = "1" ]; then

export USE_LOCAL_SDK=1

(cd "$SCRIPT_DIR/../.." && pnpm run pod-install -- --local)

fi

kieran-osgood-shopify · 2026-05-15T18:12:28Z

Merge activity

May 15, 6:12 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

kieran-osgood-shopify mentioned this pull request May 14, 2026

feat(protocol): add typescript interfaces #114

Merged

11 tasks

kieran-osgood-shopify mentioned this pull request May 14, 2026

feat: remove checkout lifecycle from react-native #116

Closed

11 tasks

kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label May 14, 2026

kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch from 06f977e to 9863b61 Compare May 14, 2026 18:04

kieran-osgood-shopify changed the base branch from kieran-osgood/05-14-featprotocoladdtypescriptinterfaces to graphite-base/115 May 14, 2026 18:26

kieran-osgood-shopify force-pushed the graphite-base/115 branch from 5ac9a6d to cacf47e Compare May 14, 2026 18:27

kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch from 9863b61 to f84aa0f Compare May 14, 2026 18:27

graphite-app Bot changed the base branch from graphite-base/115 to main May 14, 2026 18:27

kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch 2 times, most recently from 8f6af8c to 9d68bbe Compare May 14, 2026 19:13

kieran-osgood-shopify commented May 14, 2026

View reviewed changes

feat(react-native): use local android/swift project references

193682d

kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch from 9d68bbe to 193682d Compare May 14, 2026 19:23

kieran-osgood-shopify mentioned this pull request May 14, 2026

feat: remove addEventListener API #119

Draft

11 tasks

kieran-osgood-shopify marked this pull request as ready for review May 14, 2026 21:27

kieran-osgood-shopify requested a review from a team as a code owner May 14, 2026 21:27

kieran-osgood-shopify mentioned this pull request May 14, 2026

feat: explore dynamic dispatch for checkout delegate #125

Draft

11 tasks

This was referenced May 15, 2026

[Swift] Restore CheckoutDelegate with trimmed lifecycle API #131

Open

[Android] Rename CheckoutEventProcessor → CheckoutListener, drop stale callbacks #132

Open

tiagocandido approved these changes May 15, 2026

View reviewed changes

kieran-osgood-shopify mentioned this pull request May 15, 2026

feat: add first protocol event #134

Draft

11 tasks

feat: remove checkout lifecycle from react-native

27e1a45

kieran-osgood-shopify force-pushed the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch from ca7804f to 27e1a45 Compare May 15, 2026 17:57

kieran-osgood-shopify merged commit df3847b into main May 15, 2026
20 checks passed

kieran-osgood-shopify deleted the kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences branch May 15, 2026 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(react-native): use local android/swift project references#115

feat(react-native): use local android/swift project references#115
kieran-osgood-shopify merged 2 commits into
mainfrom
kieran-osgood/05-14-featreact-nativeuselocalandroid/swiftprojectreferences

kieran-osgood-shopify commented May 14, 2026 •

edited

Loading

Uh oh!

kieran-osgood-shopify commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026 •

edited

Loading

Uh oh!

kieran-osgood-shopify May 14, 2026

Uh oh!

tiagocandido left a comment

Uh oh!

tiagocandido May 15, 2026

Uh oh!

tiagocandido May 15, 2026

Uh oh!

tiagocandido May 15, 2026

Uh oh!

Uh oh!

kieran-osgood-shopify commented May 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		### CI

		CI uses the default (published) path naturally — no special flag handling. As defense-in-depth, the build wiring still ignores `USE_LOCAL_SDK=1` when the `CI` env var is set (GitHub Actions sets `CI=true` automatically).

	CI uses the default (published) path naturally — no special flag handling. As defense-in-depth, the build wiring still ignores `USE_LOCAL_SDK=1` when the `CI` env var is set (GitHub Actions sets `CI=true` automatically).
	CI currently sets `USE_LOCAL_SDK=1` so the sample and module build against the in-repo Swift and Android SDKs until the renamed `ShopifyCheckoutKit` artifacts are published to CocoaPods trunk and Maven Central.

-if [ "$use_local" = "1" ]; then
+if [ "$use_local" = "1" ] || [ "${USE_LOCAL_SDK:-0}" = "1" ]; then
+  export USE_LOCAL_SDK=1
+  (cd "$SCRIPT_DIR/../.." && pnpm run pod-install -- --local)
+fi

Conversation

kieran-osgood-shopify commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes are you making?

How to test

Before you merge

Uh oh!

kieran-osgood-shopify commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Native — Coverage Report

Uh oh!

kieran-osgood-shopify May 14, 2026

Choose a reason for hiding this comment

Uh oh!

tiagocandido left a comment

Choose a reason for hiding this comment

Uh oh!

tiagocandido May 15, 2026

Choose a reason for hiding this comment

Uh oh!

tiagocandido May 15, 2026

Choose a reason for hiding this comment

Uh oh!

tiagocandido May 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kieran-osgood-shopify commented May 15, 2026

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kieran-osgood-shopify commented May 14, 2026 •

edited

Loading

kieran-osgood-shopify commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading