Skip to content

Fix broken tests#389

Merged
thadcraft-shopify merged 1 commit intomainfrom
thad-fix_broken_tests
Apr 7, 2026
Merged

Fix broken tests#389
thadcraft-shopify merged 1 commit intomainfrom
thad-fix_broken_tests

Conversation

@thadcraft-shopify
Copy link
Copy Markdown
Contributor

@thadcraft-shopify thadcraft-shopify commented Apr 7, 2026

PRs #380 and #386 worked independently but broke grind tests when merged together. #380 added
configure_lazy_queue to the eager-mode path, setting entry_resolver on all queues including Grind. #386
reordered Static#poll to check entry_resolver before @index. Together, the grind queue's raw test ID strings
(e.g. "ATest#test_flaky") hit JSON.parse in LazyEntryResolver and crash, silently producing no results.

Additionally, even if the entries were JSON-formatted, the overhead of JSON.dump on millions of grind
entries consumed the entire --max-duration budget before any tests could run.

  • Override entry_resolver on Grind to be a no-op, since grind always eagerly loads tests and uses the @index
    built by Static#populate
  • Fix test_resolve_entry_returns_unresolved_entry_without_index_or_resolver which used an undefined
    DELIMITER constant

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@thadcraft-shopify thadcraft-shopify force-pushed the thad-fix_broken_tests branch 3 times, most recently from 4f94488 to ced261f Compare April 7, 2026 17:44
@thadcraft-shopify thadcraft-shopify marked this pull request as ready for review April 7, 2026 17:50
@thadcraft-shopify thadcraft-shopify merged commit 638c144 into main Apr 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants