Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-draftable-extension-process.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': patch
---

Remove deprecated draftable extension updates from app dev
117 changes: 0 additions & 117 deletions packages/app/src/cli/api/graphql/partners/generated/update-draft.ts

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions packages/app/src/cli/models/app/app.test-data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@ import {MigrateAppModuleSchema, MigrateAppModuleVariables} from '../../api/graph
import appWebhookSubscriptionSpec from '../extensions/specifications/app_config_webhook_subscription.js'
import appAccessSpec from '../extensions/specifications/app_config_app_access.js'
import {AppLogsSubscribeResponse} from '../../api/graphql/subscribe_to_app_logs.js'
import {
ExtensionUpdateDraftMutation,
ExtensionUpdateDraftMutationVariables,
} from '../../api/graphql/partners/generated/update-draft.js'
import {SchemaDefinitionByTargetQueryVariables} from '../../api/graphql/functions/generated/schema-definition-by-target.js'
import {SchemaDefinitionByApiTypeQueryVariables} from '../../api/graphql/functions/generated/schema-definition-by-api-type.js'
import {AppHomeSpecIdentifier} from '../extensions/specifications/app_config_app_home.js'
Expand Down Expand Up @@ -1239,12 +1235,6 @@ export const extensionCreateResponse: ExtensionCreateSchema = {
},
}

const extensionUpdateResponse: ExtensionUpdateDraftMutation = {
extensionUpdateDraft: {
userErrors: [],
},
}

const deployResponse: AppDeploySchema = {
appDeploy: {
appVersion: {
Expand Down Expand Up @@ -1391,7 +1381,6 @@ export function testDeveloperPlatformClient(stubs: Partial<DeveloperPlatformClie
appVersionByTag: (_app: MinimalOrganizationApp, _tag: string) => Promise.resolve(appVersionByTagResponse),
appVersionsDiff: (_input: AppVersionsDiffVariables) => Promise.resolve(appVersionsDiffResponse),
createExtension: (_input: ExtensionCreateVariables) => Promise.resolve(extensionCreateResponse),
updateExtension: (_input: ExtensionUpdateDraftMutationVariables) => Promise.resolve(extensionUpdateResponse),
deploy: (_input: AppDeployVariables) => Promise.resolve(deployResponse),
release: (_input: {app: MinimalAppIdentifiers; version: AppVersionIdentifiers}) => Promise.resolve(releaseResponse),
generateSignedUploadUrl: (_app: MinimalAppIdentifiers) => Promise.resolve(generateSignedUploadUrlResponse),
Expand Down
8 changes: 0 additions & 8 deletions packages/app/src/cli/models/app/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {AppConfigurationUsedByCli} from '../extensions/specifications/types/app_
import {EditorExtensionCollectionType} from '../extensions/specifications/editor_extension_collection.js'
import {UIExtensionSchema} from '../extensions/specifications/ui_extension.js'
import {CreateAppOptions, Flag} from '../../utilities/developer-platform-client.js'
import {AppAccessSpecIdentifier} from '../extensions/specifications/app_config_app_access.js'
import {configurationFileNames} from '../../constants.js'
import {ApplicationURLs} from '../../services/dev/urls.js'
import {patchAppHiddenConfigFile} from '../../services/app/patch-app-configuration-file.js'
Expand Down Expand Up @@ -228,7 +227,6 @@ export interface AppInterface<
allExtensions: ExtensionInstance[]
realExtensions: ExtensionInstance[]
nonConfigExtensions: ExtensionInstance[]
draftableExtensions: ExtensionInstance[]
errors: AppErrors
hiddenConfig: AppHiddenConfig
includeConfigOnDeploy: boolean | undefined
Expand Down Expand Up @@ -328,12 +326,6 @@ export class App<
return this.realExtensions.filter((ext) => !ext.isAppConfigExtension)
}

get draftableExtensions() {
return this.realExtensions.filter(
(ext) => ext.isUUIDStrategyExtension || ext.specification.identifier === AppAccessSpecIdentifier,
)
}

setDevApplicationURLs(devApplicationURLs: ApplicationURLs) {
this.patchAppConfiguration(devApplicationURLs)
this.realExtensions.forEach((ext) => ext.patchWithAppDevURLs(devApplicationURLs))
Expand Down
Loading
Loading