Skip to content

[Performance] Memoize firstPartyDev function#8031

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-first-party-dev-9117462479887176241
Draft

[Performance] Memoize firstPartyDev function#8031
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-first-party-dev-9117462479887176241

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

What is this PR?

This PR introduces memoization for the firstPartyDev function in packages/cli-kit/src/public/node/context/local.ts. This optimization caches the result of the SHOPIFY_CLI_1P_DEV environment variable check when called with the default process.env. This reduces redundant calls to isTruthy and environment lookups during CLI execution.

Why is it needed?

Performance optimization to reduce redundant environment variable lookups and string parsing in high-frequency execution paths.

How to test your changes?

CI

Checkbox

  • I have read the CONTRIBUTING.md document.
  • I have added/updated tests for the changes.
  • I have updated the documentation (if applicable).
  • I have followed the style guide.

PR created automatically by Jules for task 9117462479887176241 started by @gonzaloriestra

Memoize the firstPartyDev function in @shopify/cli-kit to avoid redundant environment variable lookups. Added a reset function for test isolation and updated unit tests to verify the behavior.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/local.d.ts
@@ -70,6 +70,10 @@ export declare function alwaysLogMetrics(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if SHOPIFY_CLI_1P is truthy.
  */
 export declare function firstPartyDev(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Resets the memoized value for the first party dev check.
+ */
+export declare function _resetFirstPartyDevCache(): void;
 /**
  * Returns true if the CLI can run the "doctor-release" command.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant