Skip to content

Refactor printStatus#37

Merged
forge33 merged 1 commit into
masterfrom
pb/refactor_print_stats
May 28, 2026
Merged

Refactor printStatus#37
forge33 merged 1 commit into
masterfrom
pb/refactor_print_stats

Conversation

@forge33
Copy link
Copy Markdown

@forge33 forge33 commented May 25, 2026

Related issues:

Description

This PR refactors printStatus in migrator.go to extract the metric calculation block within printStatus and simplify the printing around this. This will allow us to reuse the snapshot of the metrics taken further on when emitting to Statsd.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

🎩

Screenshot 2026-05-25 at 2 08 33 PM Screenshot 2026-05-25 at 2 10 24 PM

Sample row-copy, DML, backlog, and lag once per tick into a snapshot
passed to printStatus, with reportStatus as the single entry point for
status output.

Co-authored-by: Cursor <cursoragent@cursor.com>
@forge33 forge33 added the #gsd:50633 Data Storage: gh-ost Observability Instrumentation label May 25, 2026
@forge33 forge33 changed the title Refactor status reporting around migrationProgressSnapshot. Refactor printStatus May 25, 2026
@forge33 forge33 marked this pull request as ready for review May 25, 2026 17:43
@forge33 forge33 requested review from coding-chimp and grodowski May 27, 2026 14:03
@forge33 forge33 merged commit eb43415 into master May 28, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50633 Data Storage: gh-ost Observability Instrumentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants