Emit replication and heartbeat lag#40
Merged
Merged
Conversation
forge33
force-pushed
the
pb/emit_rep_hb_lag_metrics
branch
from
176c695 to
7b25a86
Compare
grodowski
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: github#1672
Closes: https://github.com/Shopify/schema-migrations/issues/5455
Description
This PR adds both replica lag and heartbeat lag so dashboards can correlate throttling with the upstream cause.
This is done by adding a per status tick:
gh_ost.lag.replication_seconds(histogram) —migrationContext.GetCurrentLagDuration().Seconds()gh_ost.lag.heartbeat_seconds(histogram) —migrationContext.TimeSinceLastHeartbeatOnChangelog().Seconds()Tagged with
throttled:true|false.This results in some nice lag visualizations, which will indicate if gh-ost is throttled or not
script/cibuildreturns with no formatting errors, build errors or unit test errors.