Consolidate metrics emit helpers#43
Open
forge33 wants to merge 1 commit into
Open
Conversation
forge33
force-pushed
the
pb/consolidate_metrics_emitters
branch
2 times, most recently
from
aa3774f to
63e4992
Compare
forge33
force-pushed
the
pb/consolidate_metrics_emitters
branch
from
63e4992 to
bd9bdb1
Compare
Keep the small metric emission helpers, runtime reporter, and their tests together so the metrics package has fewer one-function files.
forge33
force-pushed
the
pb/consolidate_metrics_emitters
branch
from
bd9bdb1 to
c4e2b06
Compare
mtaner
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: github#1672
Description
Emit...metric helpers into a singlego/metrics/emit.gofile.go/metrics/emit_test.go.🎩
Tophatted as part of #42 #45 #46 #47
script/cibuildreturns with no formatting errors, build errors or unit test errors.