Store instances in cursor#709
Merged
Merged
Conversation
Mangara
force-pushed
the
mangara-cursor-instances
branch
from
dd06212 to
bf3224e
Compare
MatthewRBruce
approved these changes
May 13, 2026
CelinaAssal
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
In the newly introduced parallel enumerators, the cursor only stored the instance number, but not the total number of instances. If
instanceschanged between when child jobs were enqueued and when they ran, the partition predicate would shift underneath already-enqueued children, silently skipping or double-processing records.This PR stores the total number of instances in the cursor as well, and makes child jobs always use the
instancesfrom the cursor. With this change, theinstancesgets locked in when the job first runs and enqueues child jobs.