Skip to content

fix: update lax BooleanDrop expected value to match StandardBooleanDrop#154

Merged
tobi merged 1 commit into
Shopify:mainfrom
tobi:fix-lax-booleandrop-expected-value
Jul 8, 2026
Merged

fix: update lax BooleanDrop expected value to match StandardBooleanDrop#154
tobi merged 1 commit into
Shopify:mainfrom
tobi:fix-lax-booleandrop-expected-value

Conversation

@tobi

@tobi tobi commented Jul 8, 2026

Copy link
Copy Markdown
Member

Problem

liquid-spec 2.0.0 loads standard_drops.rb after liquid_ruby.rb (line 613), so instantiate:BooleanDrop now creates StandardBooleanDrop (to_s"true"/"false") instead of the legacy BooleanDrop (to_s"Yay"/"Nay").

The non-lax liquid_ruby/variable_type_filters.yml was already updated to expect "true", but the lax version (liquid_ruby_lax/variable_type_filters.yml) was missed — it still expects "Yay".

Confirmation

Reference liquid (Shopify/liquid) also renders "true":

require "liquid"
require "liquid/spec/deps/liquid_ruby"
f = Liquid::Spec::ClassRegistry.all["BooleanDrop"]
d = f.call({"value" => true})
Liquid::Template.parse("{{ d }}").render({"d" => d})
# => "true"

Fix

2-line change: update the hint and expected value to match StandardBooleanDrop behavior, consistent with the non-lax suite.

liquid-spec 2.0.0 loads standard_drops.rb after liquid_ruby.rb, so
instantiate:BooleanDrop now creates StandardBooleanDrop (to_s → 'true')
not the legacy BooleanDrop (to_s → 'Yay'). The non-lax
liquid_ruby/variable_type_filters.yml was already updated to expect
'true', but the lax version was missed.

Reference liquid also renders 'true', confirming 'Yay' is stale.
@tobi tobi merged commit 96572fb into Shopify:main Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant