Migrate Sorbet signatures to RBS comments#455
Merged
Conversation
Morriar
force-pushed
the
at/rbs-comment-signatures
branch
from
fa09654 to
52480ca
Compare
| thor (>= 1.2.0) | ||
| tsort | ||
| thor (1.5.0) | ||
| thor (1.4.0) |
Contributor
Author
There was a problem hiding this comment.
Good catch, not sure why bundler decided to downgrade some gems because I remove sorbet-runtime
Contributor
There was a problem hiding this comment.
Downgrades are still there
Morriar
force-pushed
the
at/rbs-comment-signatures
branch
from
52480ca to
fdeee74
Compare
paracycle
approved these changes
May 6, 2026
paracycle
left a comment
paracycle
left a comment
Member
There was a problem hiding this comment.
Other than the lockfile changes that @hmcguire-shopify pointed out, I think this is great!
rafaelfranca
force-pushed
the
at/rbs-comment-signatures
branch
from
fdeee74 to
74b0047
Compare
* Use conservative rubocop bump (1.69.0 instead of 1.86.1) to minimize transitive dependency changes * Add minitest-mock gem (extracted from minitest 6) to restore Object#stub * Require "parser" instead of sub-files to fix AST constant load order with parser 3.3.11.1 * Use Prism::Translation::Parser::Builder as base class for TolerateInvalidUtf8Builder to fix Prism 1.9.0 deprecation warnings * Update integration test to match new nil error message after T.must removal
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
…r and RunContext.
rafaelfranca
force-pushed
the
at/rbs-comment-signatures
branch
from
fba1a83 to
c0f9886
Compare
edavey
added a commit
to alphagov/content-block-manager
that referenced
this pull request
May 12, 2026
Packwerk 3.3.0 no longer implicitly loads sorbet-runtime (Shopify/packwerk#455), causing packwerk-extensions 0.3.0 to fail with "uninitialized constant Packwerk::Privacy::T" when individual checkers are required directly. We resolve this issue (rubyatscale/packwerk-extensions#66) by requiring the top-level entrypoint, which explicitly loads sorbet-runtime before the checkers. This also loads all packwerk-extensions checkers (privacy, visibility, folder_privacy, layer) rather than just privacy, though unused checkers remain inactive unless configured in package.yml files.
dduugg
added a commit
to rubyatscale/packwerk-extensions
that referenced
this pull request
May 29, 2026
#68) * Update gem rbis * Modernize Sorbet tooling and pin rubocop-sorbet for new T.let cops Bump sorbet, sorbet-runtime, tapioca, spoom, rbi, and rbs to current versions and regenerate the gem RBIs to match. Pin rubocop-sorbet to Shopify/rubocop-sorbet@7b7d3cb (post-#367 and post-#372) so the not-yet-released Sorbet/RedundantTLetForLiteral and Sorbet/RedundantTLet cops are available. * Remove redundant T.let on literals via Sorbet cops Apply Sorbet/RedundantTLetForLiteral and Sorbet/RedundantTLet autocorrections. Sorbet infers the type of literal constants automatically, so the explicit T.let wrappers were redundant. * Migrate type annotations to RBS comments and drop sorbet-runtime Replace Sorbet's runtime DSL with inline RBS comment annotations so the gem no longer depends on sorbet-runtime at runtime, matching upstream packwerk (Shopify/packwerk#455). - Enable --parser=prism and --enable-experimental-rbs-comments in sorbet/config - Translate all sig blocks to #: RBS comments (via spoom) - Convert the T::Struct Package classes to plain classes with RBS-annotated attr_readers and keyword initializers - Replace T.let / T.must / extend T::Sig with inline RBS annotations - Drop require 'sorbet-runtime' and the sorbet-runtime gem dependency * Trim rubocop config for the RBS migration - Allow RBS inline annotation comments (Layout/LeadingCommentSpace) - Set TargetRubyVersion to 3.2 (matches required_ruby_version), fixing Lint/RedundantRequireStatement on the binstubs - Remove disabled-cop entries that no longer have any violations, including Style/TrivialAccessors (its Sorbet-sig rationale is moot now that RBS makes annotated attr_readers clean) * Bump minimum Ruby version to 3.3 The modernized Sorbet toolchain pulls in rbi 0.3.12, which requires Ruby >= 3.3. Raise required_ruby_version and TargetRubyVersion to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate all Sorbet
sigblocks and type annotations to RBS comment signatures, allowing us to drop the runtime dependency onsorbet-runtime.The main goal is to remove the
sorbet-runtimedependency from the gem. This eliminates the runtime overhead of signature validation and method wrapping, boosting performance for all Packwerk users — especially on large codebases where the cost ofsorbet-runtimeadds up across thousands of file checks.What changed
sigblocks to#:RBS comment signaturesT.let,T.cast,T.must,T.bind,T.unsafeto RBS comment equivalents (#: as Type,#: as !nil, etc.)T.type_aliasto#: type name = ...RBS syntaxT::Structsubclasses to plain Ruby classesextend T::Sig,extend T::Helpers,T::Genericsusagesorbet-runtimefrom gemspec dependenciesdisable_sorbet.rbshim (no longer needed)